fix(filters): Slider default operator should be greater or equal (>=) (…

…#793)
ghiscoding · Nov 5, 2022 · b895864 · b895864
1 parent 2ad02d2
commit b895864
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/packages/common/src/filters/__tests__/singleSliderFilter.spec.ts b/packages/common/src/filters/__tests__/singleSliderFilter.spec.ts
@@ -85,7 +85,7 @@ describe('SingleSliderFilter', () => {
 
     jest.runAllTimers(); // fast-forward timer
 
-    expect(callbackSpy).toHaveBeenLastCalledWith(new CustomEvent('change'), { columnDef: mockColumn, operator: 'EQ', searchTerms: [2], shouldTriggerQuery: true });
+    expect(callbackSpy).toHaveBeenLastCalledWith(new CustomEvent('change'), { columnDef: mockColumn, operator: 'GE', searchTerms: [2], shouldTriggerQuery: true });
     expect(rowMouseEnterSpy).toHaveBeenCalledWith({ column: mockColumn, grid: gridStub }, expect.anything());
   });
 
@@ -102,7 +102,7 @@ describe('SingleSliderFilter', () => {
     const filterFilledElms = divContainer.querySelectorAll('.search-filter.slider-container.filter-duration.filled');
 
     expect(filterFilledElms.length).toBe(1);
-    expect(callbackSpy).toHaveBeenLastCalledWith(new CustomEvent('change'), { columnDef: mockColumn, operator: 'EQ', searchTerms: [3], shouldTriggerQuery: true });
+    expect(callbackSpy).toHaveBeenLastCalledWith(new CustomEvent('change'), { columnDef: mockColumn, operator: 'GE', searchTerms: [3], shouldTriggerQuery: true });
   });
 
   it('should be able to call "setValues" and set empty values and the input to not have the "filled" css class', () => {

diff --git a/packages/common/src/filters/sliderFilter.ts b/packages/common/src/filters/sliderFilter.ts
@@ -81,7 +81,7 @@ export class SliderFilter implements Filter {
     if (this.sliderType === 'compound') {
       return OperatorType.empty;
     } else if (this.sliderType === 'single') {
-      return OperatorType.equal;
+      return OperatorType.greaterThanOrEqual;
     }
     return this.gridOptions.defaultFilterRangeOperator || OperatorType.rangeInclusive;
   }