fix: the devMode should be false or an object with other options

ghiscoding · Dec 8, 2023 · ac57992 · ac57992
1 parent b3ec90d
commit ac57992
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 6 deletions.
diff --git a/packages/common/src/core/slickGrid.ts b/packages/common/src/core/slickGrid.ts
@@ -2417,7 +2417,7 @@ export class SlickGrid<TData = any, C extends Column<TData> = Column<TData>, O e
     if (!this.stylesheet) {
       const sheets: any = (this._options.shadowRoot || document).styleSheets;
 
-      if (typeof this.options.devMode?.ownerNodeIndex === 'number' && this.options.devMode.ownerNodeIndex >= 0) {
+      if (this.options.devMode && typeof this.options.devMode.ownerNodeIndex === 'number' && this.options.devMode.ownerNodeIndex >= 0) {
         sheets[this.options.devMode.ownerNodeIndex].ownerNode = this._style;
       }
 
@@ -3749,7 +3749,7 @@ export class SlickGrid<TData = any, C extends Column<TData> = Column<TData>, O e
   }
 
   getViewportWidth() {
-    this.viewportW = parseFloat(getInnerSize(this._container, 'width') as unknown as string) || this.options.devMode?.containerClientWidth || 0;
+    this.viewportW = parseFloat(getInnerSize(this._container, 'width') as unknown as string) || (this.options.devMode && this.options.devMode.containerClientWidth) || 0;
     return this.viewportW;
   }
 

diff --git a/packages/common/src/interfaces/gridOption.interface.ts b/packages/common/src/interfaces/gridOption.interface.ts
@@ -259,14 +259,12 @@ export interface GridOption<C extends Column = Column> {
   /** Default cell Formatter that will be used by the grid */
   defaultFormatter?: Formatter;
 
-  /** Escape hatch geared towards testing Slickgrid in jsdom based environments to circumvent the lack of stylesheet.ownerNode and clientWidth calculations */
-  devMode?: false & { ownerNodeIndex?: number; containerClientWidth?: number; };
+  /** Escape hatch geared towards testing Slickgrid in JSDOM based environments to circumvent the lack of stylesheet.ownerNode and clientWidth calculations */
+  devMode?: false | { ownerNodeIndex?: number; containerClientWidth?: number; };
 
   /** Do we have paging enabled? */
   doPaging?: boolean;
 
-  /** Escape hatch geared towards testing Slickgrid in JSDOM based environments to circumvent the lack of stylesheet.ownerNode and clientWidth calculations */
-  devMode?: false | { ownerNodeIndex?: number; containerClientWidth?: number; };
 
   /** Draggable Grouping Plugin options & events */
   draggableGrouping?: DraggableGrouping;