Skip to content

Commit

Permalink
feat(editor): add onRendered lifecycle callback option (#1410)
Browse files Browse the repository at this point in the history
- with the new Dark Mode, we needed a way to add attributes to the composite modal element when using Bootstrap, this new lifecycle is to help with that
  • Loading branch information
ghiscoding authored Mar 2, 2024
1 parent 25f1a75 commit 9d348d6
Show file tree
Hide file tree
Showing 4 changed files with 25 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -986,6 +986,7 @@ export default class Example12 {
// showResetButtonOnEachEditor: true,
onClose: () => Promise.resolve(confirm('You have unsaved changes, are you sure you want to close this window?')),
onError: (error) => alert(error.message),
// onRendered: (modalElm) => console.log(modalElm),
onSave: (formValues, _selection, dataContextOrUpdatedDatasetPreview) => {
const serverResponseDelay = 50;

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -107,6 +107,9 @@ export interface CompositeEditorOpenDetailOption {
/** onError callback allows user to override what the system does when an error (error message & type) is thrown, defaults to console.log */
onError?: (error: OnErrorOption) => void;

/** onRendered callback allows the user to optionally execute something after the modal is created and rendered in the DOM (for example add Bootstrap `bs-data-theme="dark"` attribute to the modal element) */
onRendered?: (modalElm: HTMLDivElement) => void;

/**
* onSave callback will be triggered (when defined) after user clicked the save/apply button,
* this callback is used when connecting a backend server with custom code to execute after clicking the save/apply button
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -569,6 +569,22 @@ describe('CompositeEditorService', () => {
expect(compositeContainerElm).toBeTruthy();
});

it('should execute "onRendered" callback after creating & rendering the composite modal window', () => {
const mockProduct = { id: 222, address: { zip: 123456 }, product: { name: 'Product ABC', price: 12.55 } };
jest.spyOn(gridStub, 'getDataItem').mockReturnValue(mockProduct);
const mockOnRenderedCallback = jest.fn();

component = new SlickCompositeEditorComponent();
component.init(gridStub, container);
component.openDetails({ headerTitle: 'Details', onRendered: mockOnRenderedCallback });
const compositeContainerElm = document.querySelector('div.slick-editor-modal.slickgrid_123456') as HTMLSelectElement;

expect(mockOnRenderedCallback).toHaveBeenCalledWith(expect.any(HTMLDivElement));
expect(component).toBeTruthy();
expect(component.constructor).toBeDefined();
expect(compositeContainerElm).toBeTruthy();
});

it('should execute "onClose" callback when user confirms the closing of the modal when "onClose" callback is defined', (done) => {
const mockProduct = { id: 222, address: { zip: 123456 }, productName: 'Product ABC', price: 12.55, field2: 'Test' };
jest.spyOn(gridStub, 'getDataItem').mockReturnValue(mockProduct);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -484,6 +484,11 @@ export class SlickCompositeEditorComponent implements ExternalResource {
document.body.classList.add('slick-modal-open'); // add backdrop to body
this._bindEventService.bind(document.body, 'click', this.handleBodyClicked.bind(this));

// execute lifecycle callback after the modal window is created and rendered in the DOM
if (typeof this._options.onRendered === 'function') {
this._options.onRendered(this._modalElm);
}

this._editors = {};
this._editorContainers = modalColumns.map(col => modalBodyElm.querySelector<HTMLDivElement>(`[data-editorid=${col.id}]`)) || [];
this._compositeOptions = { destroy: this.disposeComponent.bind(this), modalType, validationMsgPrefix: '* ', formValues: {}, editors: this._editors };
Expand Down

0 comments on commit 9d348d6

Please sign in to comment.