Skip to content

Commit

Permalink
refactor(code): simple code cleanup & change website port
Browse files Browse the repository at this point in the history
  • Loading branch information
ghiscoding committed Apr 26, 2020
1 parent 09b2326 commit 98f2b5e
Show file tree
Hide file tree
Showing 7 changed files with 6 additions and 9 deletions.
2 changes: 1 addition & 1 deletion .vscode/launch.json
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
"type": "chrome",
"request": "launch",
"breakOnLoad": false,
"url": "http://localhost:8088",
"url": "http://localhost:8888",
"webRoot": "${workspaceRoot}",
"userDataDir": "${workspaceRoot}/.chrome",
"trace": true,
Expand Down
1 change: 0 additions & 1 deletion packages/common/src/extensions/extensionUtility.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@

import { Column } from '../interfaces';
import { Constants } from '../constants';
import { ExtensionName } from '../enums/extensionName.enum';
import { SharedService } from '../services/shared.service';
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { OperatorType } from '../enums/operatorType.enum';
import { FilterCondition, FilterConditionOption } from '../interfaces/index';
import { testFilterCondition } from './filterUtilities';
import { OperatorType } from '../enums';

export const stringFilterCondition: FilterCondition = (options: FilterConditionOption) => {
// make sure the cell value is a string by casting it when possible
Expand Down
2 changes: 1 addition & 1 deletion packages/common/src/interfaces/grouping.interface.ts
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import { Aggregator } from './aggregator.interface';
import { GroupingComparerItem } from './groupingComparerItem.interface';
import { GroupingFormatterItem } from './groupingFormatterItem.interface';
import { SortDirectionNumber } from '../enums';
import { SortDirectionNumber } from '../enums/sortDirectionNumber.enum';

export type GroupingGetterFunction = (value: any) => string;

Expand Down
4 changes: 1 addition & 3 deletions packages/common/src/interfaces/treeDataOption.interface.ts
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
import { FieldType } from '../enums/fieldType.enum';
import { Aggregator } from './aggregator.interface';
import { SortComparer } from './sorter.interface';
import { SortDirection, SortDirectionString } from '../enums';
import { SortDirection, SortDirectionString } from '../enums/index';

export interface TreeDataOption {
/** Column Id of which column in the column definitions has the Tree Data, there can only be one with a Tree Data. */
Expand Down
2 changes: 1 addition & 1 deletion packages/common/src/services/pubSub.service.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { Subscription } from '../interfaces';
import { Subscription } from '../interfaces/index';

export abstract class PubSubService {
/**
Expand Down
2 changes: 1 addition & 1 deletion packages/web-demo-vanilla-bundle/webpack.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ const nodeModulesDir = path.resolve(__dirname, 'node_modules');
const platform = {
hmr: false,
open: true,
port: 8088,
port: 8888,
host: 'localhost',
output: 'dist'
};
Expand Down

0 comments on commit 98f2b5e

Please sign in to comment.