Skip to content

Commit

Permalink
fix: adding dataset hierarchical item shouldn't cause scroll flickeri…
Browse files Browse the repository at this point in the history
…ng (#1076)

- calling `datasetHierarchical` setter shouldn't cause scroll flickering, this was caused a call to the DataView `setItems` with an empty array that was meant to clear the dataset before recreating it, however this is certainly not needed since calling the `datasetHierarchical` setter will then trigger a new sort which will indirectly call DataView setItems anyway
  • Loading branch information
ghiscoding authored Aug 17, 2023
1 parent e3beee2 commit 8536e0e
Showing 1 changed file with 0 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -193,7 +193,6 @@ export class SlickVanillaGridBundle {

// when a hierarchical dataset is set afterward, we can reset the flat dataset and call a tree data sort that will overwrite the flat dataset
if (this.dataView && newHierarchicalDataset && this.slickGrid && this.sortService?.processTreeDataInitialSort) {
this.dataView.setItems([], this._gridOptions?.datasetIdPropertyName ?? 'id');
this.sortService.processTreeDataInitialSort();

// we also need to reset/refresh the Tree Data filters because if we inserted new item(s) then it might not show up without doing this refresh
Expand Down

0 comments on commit 8536e0e

Please sign in to comment.