chore: rollback Cypress reporter & PR summary (#1364)

* chore: rollback Cypress reporter & PR summary
ghiscoding · Jan 24, 2024 · 4ce140c · 4ce140c
1 parent c43e67a
commit 4ce140c
Show file tree

Hide file tree

Showing 6 changed files with 16 additions and 344 deletions.
diff --git a/.github/workflows/cypress.yml b/.github/workflows/cypress.yml
@@ -15,10 +15,6 @@ concurrency:
   group: ${{ github.workflow }}-${{ github.ref }}
   cancel-in-progress: true
 
-permissions:
-  checks: write
-  pull-requests: write
-
 jobs:
   run:
     strategy:
@@ -77,38 +73,22 @@ jobs:
         run: pnpm serve:demo &
 
       - name: Run Cypress E2E tests
-        run: pnpm cypress:ci
-        # uses: cypress-io/github-action@v6
-        # with:
-        #   install: false
-        #   # working-directory: packages/dnd
-        #   start: pnpm serve:demo
-        #   # start: pnpm serve:vite
-        #   wait-on: 'http://localhost:8888'
-        #   config-file: test/cypress.config.ts
-        #   browser: chrome
-        #   record: true
-        # env:
-        #   # pass the Dashboard record key as an environment variable
-        #   CYPRESS_RECORD_KEY: ${{ secrets.CYPRESS_RECORD_KEY }}
-        #   # pass GitHub token to allow accurately detecting a build vs a re-run build
-        #   GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
-        #   Cypress_extended: true
-
-      - name: Upload Event File
-        uses: actions/upload-artifact@v4
-        with:
-          name: Event File
-          path: ${{ github.event_path }}
-
-      - name: Upload E2E Test Results
-        if: always()
-        uses: actions/upload-artifact@v4
+        uses: cypress-io/github-action@v6
         with:
-          name: Cypress E2E Test Results
-          path: |
-            test/cypress-report/**/*.json
-            test/cypress-report/**/*.xml
+          install: false
+          # working-directory: packages/dnd
+          start: pnpm serve:demo
+          # start: pnpm serve:vite
+          wait-on: 'http://localhost:8888'
+          config-file: test/cypress.config.ts
+          browser: chrome
+          record: true
+        env:
+          # pass the Dashboard record key as an environment variable
+          CYPRESS_RECORD_KEY: ${{ secrets.CYPRESS_RECORD_KEY }}
+          # pass GitHub token to allow accurately detecting a build vs a re-run build
+          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+          Cypress_extended: true
 
       - uses: actions/upload-artifact@v4
         if: failure()
@@ -131,4 +111,4 @@ jobs:
         uses: peaceiris/actions-gh-pages@v3
         with:
           github_token: ${{ secrets.GITHUB_TOKEN }}
-          publish_dir: ./website
+          publish_dir: ./website
diff --git a/.github/workflows/publish-cypress-results.yml b/.github/workflows/publish-cypress-results.yml
diff --git a/package.json b/package.json
@@ -68,7 +68,6 @@
     "@typescript-eslint/parser": "^6.19.0",
     "cross-env": "^7.0.3",
     "cypress": "^13.6.3",
-    "cypress-multi-reporters": "^1.6.4",
     "dotenv": "^16.3.2",
     "eslint": "^8.56.0",
     "eslint-plugin-cypress": "^2.15.1",
@@ -81,8 +80,6 @@
     "jest-extended": "^4.0.2",
     "jsdom": "^23.2.0",
     "jsdom-global": "^3.0.2",
-    "mocha": "^10.2.0",
-    "mochawesome": "^7.1.3",
     "moment-mini": "^2.29.4",
     "npm-run-all2": "^6.1.1",
     "pnpm": "^8.14.1",

diff --git a/packages/common/src/extensions/slickRowBasedEdit.ts b/packages/common/src/extensions/slickRowBasedEdit.ts
@@ -135,7 +135,6 @@ export class SlickRowBasedEdit {
     this._eventHandler.subscribe(dataView.onRowsOrCountChanged, this.handleAllRowRerender.bind(this));
 
     this.translate();
-    this._grid.invalidate();
   }
 
   destroy() {