Skip to content

Commit

Permalink
fix: escape glob pattern for SASS copy to work in CI
Browse files Browse the repository at this point in the history
- fixes an issue when trying to publish ms-select-vanilla lib with npm provenance, I found that it was missing some SASS files even though it was working fine locally, it turns out that as pointed out in the `copyfiles` lib, we are better off escaping copyfiles glob patterns in npm scripts
> if your terminal doesn't support globstars then you can quote them
  • Loading branch information
ghiscoding-SE committed Nov 22, 2023
1 parent f651a11 commit 0590b24
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion packages/common/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@
"sass-build-task:scss-compile:salesforce-lite": "sass src/styles/slickgrid-theme-salesforce.lite.scss dist/styles/css/slickgrid-theme-salesforce.lite.css --style=compressed --quiet-deps --no-source-map --load-path=node_modules",
"sass:build": "run-p sass-build-task:scss-compile:*",
"postsass:build": "postcss --no-map --use cssnano --use autoprefixer --dir dist/styles/css dist/styles/css --style=compressed --quiet-deps --no-source-map",
"sass:copy": "cross-env copyfiles -f src/styles/*.scss dist/styles/sass",
"sass:copy": "cross-env copyfiles -f \"./src/styles/*.scss\" dist/styles/sass",
"sass:watch:bootstrap": "npm run sass-build-task:scss-compile:bootstrap -- --watch",
"sass:watch:material": "npm run sass-build-task:scss-compile:material -- --watch",
"sass:watch:salesforce": "npm run sass-build-task:scss-compile:salesforce -- --watch",
Expand Down

0 comments on commit 0590b24

Please sign in to comment.