-
-
Notifications
You must be signed in to change notification settings - Fork 29
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
feat(components): extract CompositeEditor & EmptyWarning Components (#…
…191) * feat(components): extract CompositeEditor & EmptyWarning Components - extract into 2 separate monorepo packages so it can be used in other frameworks like Aurelia-Slickgrid - keep full unit test coverage on both components * refactor(core): remove unused build targets avoid circleci out of memory * refactor(style): tweak Composite Editor styling to work with BS4 * build(dev): update few npm packages & rebuild slick bundle vanilla zip
- Loading branch information
1 parent
b856c47
commit 00cf9a2
Showing
45 changed files
with
581 additions
and
235 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| [](https://opensource.org/licenses/MIT) | ||
| [](http://www.typescriptlang.org/) | ||
| [](https://lerna.js.org/) | ||
| [](https://www.npmjs.com/package/@slickgrid-universal/composite-editor-component) | ||
| [](https://www.npmjs.com/package/@slickgrid-universal/composite-editor-component) | ||
|
|
||
| [](https://circleci.com/gh/ghiscoding/workflows/slickgrid-universal/tree/master) | ||
| [](https://www.cypress.io/) | ||
| [](https://github.com/facebook/jest) | ||
| [](https://codecov.io/gh/ghiscoding/slickgrid-universal) | ||
|
|
||
| ## Vanilla Bundle | ||
| #### @slickgrid-universal/composite-editor-component | ||
|
|
||
| Vanilla Bundle implementation of a Composite Editor Modal Window which can do the following | ||
| - Create | ||
| - Update | ||
| - Mass Update Changes | ||
| - Mass Selection Changes (similar to Mass Update but only for the selected items) | ||
|
|
||
| ### Installation | ||
| Follow the instruction provided in the main [README](https://github.com/ghiscoding/slickgrid-universal#installation), you can see a demo by looking at the [GitHub Demo](https://ghiscoding.github.io/slickgrid-universal) page and click on "Export to CSV" from the Grid Menu (aka hamburger menu). |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,48 @@ | ||
| { | ||
| "name": "@slickgrid-universal/composite-editor-component", | ||
| "version": "0.4.0", | ||
| "description": "Slick Composite Editor Component - Vanilla Implementation of a Composite Editor Modal Window Component", | ||
| "browser": "src/index.ts", | ||
| "main": "dist/commonjs/index.js", | ||
| "module": "dist/es2015/index.js", | ||
| "typings": "dist/commonjs/index.d.ts", | ||
| "publishConfig": { | ||
| "access": "public" | ||
| }, | ||
| "directories": { | ||
| "src": "src" | ||
| }, | ||
| "scripts": { | ||
| "build": "cross-env tsc --build", | ||
| "build:watch": "cross-env tsc --incremental --watch", | ||
| "dev": "run-s build sass:build sass:copy", | ||
| "dev:watch": "run-p build:watch", | ||
| "bundle": "run-p bundle:commonjs bundle:es2015", | ||
| "bundle:commonjs": "tsc --project tsconfig.build.json --outDir dist/commonjs --module commonjs", | ||
| "bundle:es2015": "cross-env tsc --project tsconfig.build.json --outDir dist/es2015 --module es2020 --target es2015", | ||
| "prebundle": "npm-run-all delete:dist", | ||
| "delete:dist": "cross-env rimraf --maxBusyTries=10 dist" | ||
| }, | ||
| "author": "Ghislain B.", | ||
| "license": "MIT", | ||
| "engines": { | ||
| "node": ">=12.0.0", | ||
| "npm": ">=6.14.0" | ||
| }, | ||
| "browserslist": [ | ||
| "last 2 version", | ||
| "> 1%", | ||
| "maintained node versions", | ||
| "not dead" | ||
| ], | ||
| "dependencies": { | ||
| "@slickgrid-universal/common": "*", | ||
| "dompurify": "^2.2.3" | ||
| }, | ||
| "devDependencies": { | ||
| "@types/webpack": "^4.41.25", | ||
| "cross-env": "^7.0.3", | ||
| "npm-run-all": "^4.1.5", | ||
| "rimraf": "^3.0.2" | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| index.ts | ||
| **/*.* |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| import * as entry from './index'; | ||
|
|
||
| describe('Testing library entry point', () => { | ||
| it('should have an index entry point defined', () => { | ||
| expect(entry).toBeTruthy(); | ||
| }); | ||
|
|
||
| it('should have all exported object defined', () => { | ||
| expect(typeof entry.SlickCompositeEditorComponent).toBe('function'); | ||
| }); | ||
| }); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| export * from './slick-composite-editor.component'; |
19 changes: 16 additions & 3 deletions
19
.../__tests__/slick-composite-editor.spec.ts → .../slick-composite-editor.component.spec.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,40 @@ | ||
| { | ||
| "compilerOptions": { | ||
| "module": "es2020", | ||
| "moduleResolution": "node", | ||
| "target": "es2015", | ||
| "lib": [ | ||
| "es2020", | ||
| "dom" | ||
| ], | ||
| "typeRoots": [ | ||
| "../typings", | ||
| "../../node_modules/@types" | ||
| ], | ||
| "outDir": "dist/2015", | ||
| "noImplicitAny": true, | ||
| "suppressImplicitAnyIndexErrors": true, | ||
| "noUnusedLocals": false, | ||
| "noUnusedParameters": false, | ||
| "noImplicitReturns": true, | ||
| "skipLibCheck": true, | ||
| "strictNullChecks": true, | ||
| "declaration": true, | ||
| "forceConsistentCasingInFileNames": true, | ||
| "experimentalDecorators": true, | ||
| "noEmitHelpers": false, | ||
| "stripInternal": true, | ||
| "sourceMap": true | ||
| }, | ||
| "exclude": [ | ||
| ".vscode", | ||
| "src/examples", | ||
| "src/resources", | ||
| "test", | ||
| "**/*.spec.ts" | ||
| ], | ||
| "include": [ | ||
| "../typings", | ||
| "**/*" | ||
| ] | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,41 @@ | ||
| { | ||
| "extends": "../tsconfig-build.json", | ||
| "compileOnSave": false, | ||
| "compilerOptions": { | ||
| "rootDir": "src", | ||
| "declarationDir": "dist/es2015", | ||
| "outDir": "dist/es2015", | ||
| "target": "es2017", | ||
| "module": "es2015", | ||
| "sourceMap": true, | ||
| "noImplicitReturns": true, | ||
| "lib": [ | ||
| "es2020", | ||
| "dom" | ||
| ], | ||
| "types": [ | ||
| "moment", | ||
| "jquery", | ||
| "node" | ||
| ], | ||
| "typeRoots": [ | ||
| "node_modules/@types", | ||
| "src/typings" | ||
| ] | ||
| }, | ||
| "exclude": [ | ||
| "cypress", | ||
| "dist", | ||
| "node_modules", | ||
| "**/*.spec.ts" | ||
| ], | ||
| "filesGlob": [ | ||
| "./src/**/*.ts", | ||
| "./test/**/*.ts", | ||
| "./custom_typings/**/*.d.ts" | ||
| ], | ||
| "include": [ | ||
| "src/**/*.ts", | ||
| "src/typings/**/*.ts" | ||
| ] | ||
| } |
Oops, something went wrong.