Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove tsup, replace with esbuild + dts with tsc #307

Merged
merged 2 commits into from
Oct 12, 2024

Conversation

ghiscoding
Copy link
Owner

@ghiscoding ghiscoding commented Oct 12, 2024

  • found the correct way to bundle a working hybrid CJS/ESM with esbuild (like before), in order to use type=module in the package.json, we need to add the .jsextension to allimports and finally we also need to clone the index.d.tsfile into copied to ad.cts` file to make both CJS/ESM working properly and have "Are the Types Wrong" be happy about it
  • removing tsup and going back to original build will help produce the build we expect

Copy link

stackblitz bot commented Oct 12, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

github-actions bot commented Oct 12, 2024

Playwright E2E Test Results

78 tests  ±0   78 ✅ ±0   1m 52s ⏱️ ±0s
69 suites ±0    0 💤 ±0 
 1 files   ±0    0 ❌ ±0 

Results for commit 9dc9a54. ± Comparison against base commit 52c15ba.

♻️ This comment has been updated with latest results.

@ghiscoding ghiscoding merged commit 21713a7 into main Oct 12, 2024
3 checks passed
@ghiscoding ghiscoding deleted the chore/dts-bundle branch October 12, 2024 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant