Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support arrow navigation #206

Closed
1 task done
morki opened this issue Feb 1, 2024 · 3 comments · Fixed by #213
Closed
1 task done

Support arrow navigation #206

morki opened this issue Feb 1, 2024 · 3 comments · Fixed by #213
Labels
Breaking Change WIP

Comments

@morki
Copy link

morki commented Feb 1, 2024

Clear and concise description of the problem

Thank you for this awesome library. But one thing that makes it unusable for our use case is missing arrow navigation in opened popup.

Suggested solution

It can be implemented.

Alternative

No response

Additional context

No response

Validations

  • Check that there isn't already an issue that request the same feature to avoid creating a duplicate.
@ghiscoding
Copy link
Owner

That was already implemented in PR #176 which was first implemented in the original library in this PR. As far as I can see, it is working fine.

@morki
Copy link
Author

morki commented Feb 1, 2024

Oh, thank you for quick response. It "kinda" works, but:

  • it is not possible navigate items when focus is in filter input
  • popup is not focused automatically when there is no filter, so to use arrow navigation, one must "tab" into it

Both of those behaviours are unintuitive, that even me as developer didn't explore it.

@ghiscoding
Copy link
Owner

ghiscoding commented Feb 1, 2024 •
edited
Loading

  • it is not possible navigate items when focus is in filter input

you just need to Tab out of the filter, I don't see a problem doing that since that is the "correct way" to focus out of a form input

Both of those behaviours are unintuitive, that even me as developer didn't explore it.

I would suggest you contribute to the project because I'm not expecting to work on this, at least not at the moment

@ghiscoding ghiscoding added the help wanted Extra attention is needed label Feb 1, 2024
@ghiscoding ghiscoding added WIP Breaking Change and removed help wanted Extra attention is needed labels Feb 15, 2024
ghiscoding added a commit that referenced this issue Feb 16, 2024
@ghiscoding
feat!: replace arrow up/down direction tabIndex by highlight, fix #206
f20d88c 
- fixes #206
- previous tabIndex implementation required to use arrow to go up/down the list OR use filter (when enabled) BUT not both at the same time, this new implementation is more UX friendly and is typically what most user will want which is to keep filter in focus but also allow to use up/down arrow at the same time
- also change selection and checkbox to use default primary color
@ghiscoding ghiscoding mentioned this issue Feb 16, 2024
Merged
ghiscoding added a commit that referenced this issue Feb 17, 2024
@ghiscoding
feat!: replace arrow up/down direction tabIndex by highlight, fix #206 (
50be59c 
#213)

* feat!: replace arrow up/down direction tabIndex by highlight, fix #206
- fixes #206
- previous tabIndex implementation required to use arrow to go up/down the list OR use filter (when enabled) BUT not both at the same time, this new implementation is more UX friendly and is typically what most user will want which is to keep filter in focus but also allow to use up/down arrow at the same time
- also change selection and checkbox to use default primary color
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Breaking Change WIP
Projects
None yet
Milestone
No milestone
2 participants
@ghiscoding @morki