fix: avoid barrel files, keep only 1 entry file (#304)

ghiscoding · Oct 5, 2024 · 64e895b · 64e895b
1 parent 2c10ebd
commit 64e895b
Show file tree

Hide file tree

Showing 28 changed files with 80 additions and 51 deletions.
diff --git a/packages/multiple-select-vanilla/build-prod.mjs b/packages/multiple-select-vanilla/build-prod.mjs
@@ -37,13 +37,16 @@ for (const format of buildFormats) {
     outfile: `dist/locales/multiple-select-all-locales.${extension}`,
   });
 
+  // - let's use TSUP to get valid hybrid (CJS/ESM) approach with are-the-types-wrong, however keep the rest of the build
   // finally, create a regular bundle as a standalone which will be accessible as MultipleSelect from the global window object
   // this file is basically a legacy alternative to import via a <script> tag
+  /*
   runBuild({
     format,
     globalName: 'MultipleSelect',
     outfile: `dist/browser/multiple-select.${extension}`,
   });
+  */
 }
 
 function runBuild(options) {

diff --git a/packages/multiple-select-vanilla/src/MultipleSelectInstance.ts b/packages/multiple-select-vanilla/src/MultipleSelectInstance.ts
@@ -2,10 +2,12 @@
  * @author zhixin wen <[email protected]>
  */
 import Constants from './constants';
-import type { HtmlStruct, MultipleSelectLocales, OptGroupRowData, OptionDataObject, OptionRowData } from './interfaces';
-import type { CloseReason, MultipleSelectOption } from './interfaces/multipleSelectOption.interface';
-import { BindingEventService, VirtualScroll } from './services';
-import { compareObjects, deepCopy, findByParam, removeDiacritics, removeUndefined, setDataKeys, stripScripts } from './utils';
+import type { HtmlStruct, OptGroupRowData, OptionDataObject, OptionRowData } from './models/interfaces';
+import type { MultipleSelectLocales } from './models/locale.interface';
+import type { CloseReason, MultipleSelectOption } from './models/multipleSelectOption.interface';
+import { BindingEventService } from './services/binding-event.service';
+import { VirtualScroll } from './services/virtual-scroll';
+import { compareObjects, deepCopy, findByParam, removeDiacritics, removeUndefined, setDataKeys, stripScripts } from './utils/utils';
 import {
   calculateAvailableSpace,
   classNameToList,

diff --git a/packages/multiple-select-vanilla/src/constants.ts b/packages/multiple-select-vanilla/src/constants.ts
@@ -1,4 +1,5 @@
-import type { LabelFilter, MultipleSelectOption, TextFilter } from './interfaces';
+import type { LabelFilter, TextFilter } from './models/interfaces';
+import type { MultipleSelectOption } from './models/multipleSelectOption.interface';
 import English from './locales/multiple-select-en-US';
 
 const BLOCK_ROWS = 50;

diff --git a/packages/multiple-select-vanilla/src/index.ts b/packages/multiple-select-vanilla/src/index.ts
@@ -1,6 +1,36 @@
-export * from './services';
-export * from './constants';
-export * from './interfaces';
-export * from './utils';
-export * from './multiple-select';
-export * from './MultipleSelectInstance';
+export type * from './models/interfaces';
+export type * from './models/locale.interface';
+export type * from './models/multipleSelectOption.interface';
+export { BindingEventService, type ElementEventListener } from './services/binding-event.service';
+export { VirtualScroll } from './services/virtual-scroll';
+export {
+  type HtmlElementPosition,
+  calculateAvailableSpace,
+  classNameToList,
+  convertItemRowToHtml,
+  createDomElement,
+  createDomStructure,
+  emptyElement,
+  findParent,
+  getElementOffset,
+  getElementSize,
+  insertAfter,
+  omitProp,
+  toggleElement,
+  toggleElementClass,
+  windowScrollPosition,
+} from './utils/domUtils';
+export {
+  compareObjects,
+  deepCopy,
+  findByParam,
+  isDefined,
+  objectRemoveEmptyProps,
+  removeDiacritics,
+  removeUndefined,
+  setDataKeys,
+  stripScripts,
+  toCamelCase,
+} from './utils/utils';
+export { multipleSelect } from './multiple-select';
+export { MultipleSelectInstance } from './MultipleSelectInstance';
diff --git a/packages/multiple-select-vanilla/src/interfaces/index.ts b/packages/multiple-select-vanilla/src/interfaces/index.ts
diff --git a/packages/multiple-select-vanilla/src/locales/multiple-select-cz-CS.ts b/packages/multiple-select-vanilla/src/locales/multiple-select-cz-CS.ts
@@ -4,7 +4,7 @@
  */
 
 import type { MultipleSelectInstance } from '../MultipleSelectInstance';
-import type { MultipleSelectLocale, MultipleSelectLocales } from '../interfaces';
+import type { MultipleSelectLocale, MultipleSelectLocales } from '../models/locale.interface';
 
 const ms =
   typeof window !== 'undefined' && window.multipleSelect !== undefined

diff --git a/packages/multiple-select-vanilla/src/locales/multiple-select-da-DK.ts b/packages/multiple-select-vanilla/src/locales/multiple-select-da-DK.ts
@@ -4,7 +4,7 @@
  */
 
 import type { MultipleSelectInstance } from '../MultipleSelectInstance';
-import type { MultipleSelectLocale, MultipleSelectLocales } from '../interfaces';
+import type { MultipleSelectLocale, MultipleSelectLocales } from '../models/locale.interface';
 
 const ms =
   typeof window !== 'undefined' && window.multipleSelect !== undefined

diff --git a/packages/multiple-select-vanilla/src/locales/multiple-select-de-DE.ts b/packages/multiple-select-vanilla/src/locales/multiple-select-de-DE.ts
@@ -4,7 +4,7 @@
  */
 
 import type { MultipleSelectInstance } from '../MultipleSelectInstance';
-import type { MultipleSelectLocale, MultipleSelectLocales } from '../interfaces';
+import type { MultipleSelectLocale, MultipleSelectLocales } from '../models/locale.interface';
 
 const ms =
   typeof window !== 'undefined' && window.multipleSelect !== undefined

diff --git a/packages/multiple-select-vanilla/src/locales/multiple-select-en-US.ts b/packages/multiple-select-vanilla/src/locales/multiple-select-en-US.ts
@@ -4,7 +4,7 @@
  */
 
 import type { MultipleSelectInstance } from '../MultipleSelectInstance';
-import type { MultipleSelectLocale, MultipleSelectLocales } from '../interfaces';
+import type { MultipleSelectLocale, MultipleSelectLocales } from '../models/locale.interface';
 
 const ms =
   typeof window !== 'undefined' && window.multipleSelect !== undefined

diff --git a/packages/multiple-select-vanilla/src/locales/multiple-select-es-ES.ts b/packages/multiple-select-vanilla/src/locales/multiple-select-es-ES.ts
@@ -4,7 +4,7 @@
  */
 
 import type { MultipleSelectInstance } from '../MultipleSelectInstance';
-import type { MultipleSelectLocale, MultipleSelectLocales } from '../interfaces';
+import type { MultipleSelectLocale, MultipleSelectLocales } from '../models/locale.interface';
 
 const ms =
   typeof window !== 'undefined' && window.multipleSelect !== undefined

diff --git a/packages/multiple-select-vanilla/src/locales/multiple-select-fr-FR.ts b/packages/multiple-select-vanilla/src/locales/multiple-select-fr-FR.ts
@@ -4,7 +4,7 @@
  */
 
 import type { MultipleSelectInstance } from '../MultipleSelectInstance';
-import type { MultipleSelectLocale, MultipleSelectLocales } from '../interfaces';
+import type { MultipleSelectLocale, MultipleSelectLocales } from '../models/locale.interface';
 
 const ms =
   typeof window !== 'undefined' && window.multipleSelect !== undefined

diff --git a/packages/multiple-select-vanilla/src/locales/multiple-select-hu-HU.ts b/packages/multiple-select-vanilla/src/locales/multiple-select-hu-HU.ts
@@ -4,7 +4,7 @@
  */
 
 import type { MultipleSelectInstance } from '../MultipleSelectInstance';
-import type { MultipleSelectLocale, MultipleSelectLocales } from '../interfaces';
+import type { MultipleSelectLocale, MultipleSelectLocales } from '../models/locale.interface';
 
 const ms =
   typeof window !== 'undefined' && window.multipleSelect !== undefined

diff --git a/packages/multiple-select-vanilla/src/locales/multiple-select-it-IT.ts b/packages/multiple-select-vanilla/src/locales/multiple-select-it-IT.ts
@@ -4,7 +4,7 @@
  */
 
 import type { MultipleSelectInstance } from '../MultipleSelectInstance';
-import type { MultipleSelectLocale, MultipleSelectLocales } from '../interfaces';
+import type { MultipleSelectLocale, MultipleSelectLocales } from '../models/locale.interface';
 
 const ms =
   typeof window !== 'undefined' && window.multipleSelect !== undefined

diff --git a/packages/multiple-select-vanilla/src/locales/multiple-select-ja-JP.ts b/packages/multiple-select-vanilla/src/locales/multiple-select-ja-JP.ts
@@ -4,7 +4,7 @@
  */
 
 import type { MultipleSelectInstance } from '../MultipleSelectInstance';
-import type { MultipleSelectLocale, MultipleSelectLocales } from '../interfaces';
+import type { MultipleSelectLocale, MultipleSelectLocales } from '../models/locale.interface';
 
 const ms =
   typeof window !== 'undefined' && window.multipleSelect !== undefined

diff --git a/packages/multiple-select-vanilla/src/locales/multiple-select-pt-BR.ts b/packages/multiple-select-vanilla/src/locales/multiple-select-pt-BR.ts
@@ -4,7 +4,7 @@
  */
 
 import type { MultipleSelectInstance } from '../MultipleSelectInstance';
-import type { MultipleSelectLocale, MultipleSelectLocales } from '../interfaces';
+import type { MultipleSelectLocale, MultipleSelectLocales } from '../models/locale.interface';
 
 const ms =
   typeof window !== 'undefined' && window.multipleSelect !== undefined

diff --git a/packages/multiple-select-vanilla/src/locales/multiple-select-ru-RU.ts b/packages/multiple-select-vanilla/src/locales/multiple-select-ru-RU.ts
@@ -4,7 +4,7 @@
  */
 
 import type { MultipleSelectInstance } from '../MultipleSelectInstance';
-import type { MultipleSelectLocale, MultipleSelectLocales } from '../interfaces';
+import type { MultipleSelectLocale, MultipleSelectLocales } from '../models/locale.interface';
 
 const ms =
   typeof window !== 'undefined' && window.multipleSelect !== undefined

diff --git a/packages/multiple-select-vanilla/src/locales/multiple-select-vi-VN.ts b/packages/multiple-select-vanilla/src/locales/multiple-select-vi-VN.ts
@@ -4,7 +4,7 @@
  */
 
 import type { MultipleSelectInstance } from '../MultipleSelectInstance';
-import type { MultipleSelectLocale, MultipleSelectLocales } from '../interfaces';
+import type { MultipleSelectLocale, MultipleSelectLocales } from '../models/locale.interface';
 
 const ms =
   typeof window !== 'undefined' && window.multipleSelect !== undefined

diff --git a/packages/multiple-select-vanilla/src/locales/multiple-select-zh-CN.ts b/packages/multiple-select-vanilla/src/locales/multiple-select-zh-CN.ts
@@ -4,7 +4,7 @@
  */
 
 import type { MultipleSelectInstance } from '../MultipleSelectInstance';
-import type { MultipleSelectLocale, MultipleSelectLocales } from '../interfaces';
+import type { MultipleSelectLocale, MultipleSelectLocales } from '../models/locale.interface';
 
 const ms =
   typeof window !== 'undefined' && window.multipleSelect !== undefined

diff --git a/packages/multiple-select-vanilla/src/locales/multiple-select-zh-TW.ts b/packages/multiple-select-vanilla/src/locales/multiple-select-zh-TW.ts
@@ -4,7 +4,7 @@
  */
 
 import type { MultipleSelectInstance } from '../MultipleSelectInstance';
-import type { MultipleSelectLocale, MultipleSelectLocales } from '../interfaces';
+import type { MultipleSelectLocale, MultipleSelectLocales } from '../models/locale.interface';
 
 const ms =
   typeof window !== 'undefined' && window.multipleSelect !== undefined

diff --git a/...lect-vanilla/src/interfaces/interfaces.ts → ...e-select-vanilla/src/models/interfaces.ts b/...lect-vanilla/src/interfaces/interfaces.ts → ...e-select-vanilla/src/models/interfaces.ts
diff --git a/...anilla/src/interfaces/locale.interface.ts → ...ct-vanilla/src/models/locale.interface.ts b/...anilla/src/interfaces/locale.interface.ts → ...ct-vanilla/src/models/locale.interface.ts
diff --git a/...erfaces/multipleSelectOption.interface.ts → .../models/multipleSelectOption.interface.ts b/...erfaces/multipleSelectOption.interface.ts → .../models/multipleSelectOption.interface.ts
diff --git a/packages/multiple-select-vanilla/src/multiple-select.ts b/packages/multiple-select-vanilla/src/multiple-select.ts
@@ -5,8 +5,8 @@
 
 import { MultipleSelectInstance } from './MultipleSelectInstance';
 import Constants from './constants';
-import type { MultipleSelectLocales } from './interfaces';
-import type { MultipleSelectOption } from './interfaces/multipleSelectOption.interface';
+import type { MultipleSelectLocales } from './models/locale.interface';
+import type { MultipleSelectOption } from './models/multipleSelectOption.interface';
 import English from './locales/multiple-select-en-US';
 
 /**

diff --git a/packages/multiple-select-vanilla/src/services/index.ts b/packages/multiple-select-vanilla/src/services/index.ts
diff --git a/packages/multiple-select-vanilla/src/services/virtual-scroll.ts b/packages/multiple-select-vanilla/src/services/virtual-scroll.ts
@@ -1,6 +1,6 @@
 import Constants from '../constants';
-import type { HtmlStruct, VirtualCache, VirtualScrollOption } from '../interfaces';
-import { convertItemRowToHtml, emptyElement } from '../utils';
+import type { HtmlStruct, VirtualCache, VirtualScrollOption } from '../models/interfaces';
+import { convertItemRowToHtml, emptyElement } from '../utils/domUtils';
 
 export class VirtualScroll {
   protected clusterRows?: number;

diff --git a/packages/multiple-select-vanilla/src/utils/domUtils.ts b/packages/multiple-select-vanilla/src/utils/domUtils.ts
@@ -1,4 +1,4 @@
-import type { HtmlStruct, InferDOMType } from '../interfaces';
+import type { HtmlStruct, InferDOMType } from '../models/interfaces';
 import { objectRemoveEmptyProps } from './utils';
 
 export interface HtmlElementPosition {

diff --git a/packages/multiple-select-vanilla/src/utils/index.ts b/packages/multiple-select-vanilla/src/utils/index.ts
diff --git a/packages/multiple-select-vanilla/tsup.config.ts b/packages/multiple-select-vanilla/tsup.config.ts
@@ -3,7 +3,7 @@ import { defineConfig } from 'tsup';
 export default defineConfig(options => [
   // for bundlers like vite, rollup, esbuild, webpack etc
   {
-    entry: ['src/**.ts'],
+    entry: ['src/index.ts'],
     format: ['esm'],
     splitting: false,
     sourcemap: true,
@@ -27,17 +27,17 @@ export default defineConfig(options => [
   },
 
   // IIFE bundle js for cdn (window object for legacy <script>)
-  // {
-  //   entry: {
-  //     'multiple-select': 'src/index.ts',
-  //   },
-  //   format: ['iife'],
-  //   globalName: 'MultipleSelect',
-  //   splitting: false,
-  //   sourcemap: true,
-  //   clean: true,
-  //   outExtension: ({ format }) => ({
-  //     js: '.iife.js',
-  //   }),
-  // },
+  {
+    entry: {
+      'browser/multiple-select': 'src/index.ts',
+    },
+    format: ['iife'],
+    globalName: 'MultipleSelect',
+    splitting: false,
+    sourcemap: true,
+    // clean: true,
+    outExtension: ({ format }) => ({
+      js: '.iife.js',
+    }),
+  },
 ]);