Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(grid): add sample for Header Grouping spanning accros multiple cols #43

Merged
merged 6 commits into from
Apr 10, 2018

Conversation

ghiscoding
Copy link
Owner

No description provided.

@ghiscoding
Copy link
Owner Author

ghiscoding commented Apr 8, 2018

@jmzagorski
You can review if you want and have time, I'll probably merge on Monday and look at a new version during the week before I leave in vacations.

Some things worth noting about this PR, Grouping Header doesn't work so well with a window resize. Probably some CSS to fix up somewhere. Also, the pre-header and header-row have to be re-created every time the grid changes (like sorting, resizing column width, ...) which is dealt properly in FilterService with grid.onHeaderRowCellRendered which calls addFilterTemplateToHeaderRow but for the pre-header I found out there was a lot more to do on that side of it and it isn't yet correct with grid resize.

I managed to do the following over the weekend

  • add support for multi-columns number indicator & tristate (in master)
  • add Column Span (colspan) demo (in master)
  • add Header Grouping spanning across multiple cols (this PR)

I'd like to get this done too, which I'm about to start working on

If you have something upcoming, let me know. The reference list #31 is getting smaller and smaller :)

@ghiscoding ghiscoding merged commit 67ff867 into master Apr 10, 2018
@ghiscoding ghiscoding deleted the feature/header-colspan branch April 12, 2018 04:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant