Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(extension): add latest slickgrid with RowMove improvements #321

Merged
merged 3 commits into from
Apr 8, 2020

Conversation

ghiscoding
Copy link
Owner

  • now create column definition just by the enableRowMoveManager flag
  • also keep row selection with dataview syncGridSelection
  • latest slickgrid version also brought the usabilityOverride callback method that was added in RowMoveManager plugin

- now create column definition just by the enableRowMoveManager flag
- also keep row selection with dataview syncGridSelection
- latest slickgrid version also brought the usabilityOverride callback method that was added in RowMoveManager plugin
@codecov
Copy link

codecov bot commented Apr 7, 2020

Codecov Report

Merging #321 into master will not change coverage by %.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #321   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          155       155           
  Lines         9139      9170   +31     
  Branches      3043      3054   +11     
=========================================
+ Hits          9139      9170   +31     
Impacted Files Coverage Δ
...lia-slickgrid/extensions/rowDetailViewExtension.ts 100.00% <ø> (ø)
.../aurelia-slickgrid/services/excelExport.service.ts 100.00% <ø> (ø)
...ia-slickgrid/extensions/rowMoveManagerExtension.ts 100.00% <100.00%> (ø)
...rc/aurelia-slickgrid/services/extension.service.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 90a752b...0163b6e. Read the comment docs.

@ghiscoding ghiscoding merged commit bf767c5 into master Apr 8, 2020
@ghiscoding ghiscoding deleted the feat/row-move-refactoring branch April 8, 2020 01:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant