[feature] Compound Filters (input & date)

[ghiscoding]

No description provided.

[ghiscoding]

@jmzagorski
If you have a chance to review by Monday night, else I will merge it anyway. Also note that there's more than just Compound Filters in the PR, I found a few issues with Pagination and Filters at work and a few of these fixes are within the PR. Lastly the first commit is for Compound Filters even though it says fixed untracked files, that was for some files that I wanted to be removed from .gitignore and though I fixed that, I was following this SO question and forgot to name the commit correctly.

Closes #26

[jmzagorski]

I will review it today. Sorry I have been MIA on some of the tasks I said I was going to do this week. I had to rewrite many of my server Apis.

[ghiscoding]

No worries, I assumed you were busy, hence if you can't do it then I will merge it. No big issues.

[jmzagorski]

do you need a this.$selectOperatorElm.off('change') here?

[ghiscoding]

oh right, I could do that one too.

[jmzagorski]

This looks real slick 👍, I was able to run it successfully in examples 4 and 5. I have one single comment for you to review and one general question: is your intention when the compound filter goes from a value such as =, >, < to blank that is defaults to equals?

[ghiscoding]

Not always equals, it depends on the type. If it's a Type String it should be Contains for the rest it will be Equals

[jmzagorski]

oh okay I see, I did not test that out in example 5 on the Name column

[ghiscoding]

Hmm I might have forgot to test that portion in a regular grid (without backend service), we should probably test it out in Example 4 or any other. I tested it in OData/GraphQL Backend Services and I have code to handle that. I think the regular grid are handled directly by their filterConditions but I can't remember totally

[ghiscoding]

It's actually a good thing you talked about this since yes I forgot to test it with a regular grid and it is in fact not working correctly. I just fixed it in my Angular-Slickgrid repo with this commit. I will apply it to the Aurelia repo tonight.

Or perhaps if you have time, I wouldn't mind if you do the changes that you mentioned and the fix for regular grid that I just talked about (on my branch). Or I can try to do them quickly during my lunch time in about 2 hours.

[jmzagorski]

I can look over your angular commit and see how to fix it.

[ghiscoding]

I assume that you are able to do the changes on the same branch right? It should be features/compound-filters if I remember correctly

[jmzagorski]

yup, I have it pulled down on my machine

[jmzagorski]

@ghiscoding
the same exact change you made in Angular works in Aurelia too. You should now be able to change local filters in example 4 and the data should filter as you expect.

[ghiscoding]

Yup I try to re-use as much code as possible between the 2 repos 😄
I'll push a release tonight then, thx for the update

EDIT
Oops I found another small issue with the date picker, I use the output type format, to detect if it has an 'h' and if so I add the time picker as well. However I forgot to make it case insensitive so it wasn't picking up 'H' (with Type DateTimeIso which uses an uppercase 'H').

I can update it myself tonight, unless you want to do it, here's the Angular commit