-
-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(selectEditors): add select grid editors #22
Merged
Merged
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
ad2a7e3
feat(selectEditors): add select grid editors
jmzagorski 81be263
docs(demo): add singleSelect and multiSelect to example3
jmzagorski 8219631
refactor(editors): use params not filter columnDef prop
jmzagorski 8c32223
refactor(editors): add i18n and open select on cell click
jmzagorski File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,4 @@ | ||
import { I18N } from 'aurelia-i18n'; | ||
import { | ||
Editor, | ||
Column, | ||
|
@@ -38,13 +39,20 @@ export class SingleSelectEditor implements Editor { | |
* The property name for labels in the collection | ||
*/ | ||
labelName: string; | ||
/** | ||
* The i18n aurelia library | ||
*/ | ||
private _i18n: I18N; | ||
|
||
constructor(private args: any) { | ||
this._i18n = this.args.column.params.i18n; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. same as before.. this will probably fail at Build, |
||
|
||
this.defaultOptions = { | ||
container: 'body', | ||
filter: false, | ||
maxHeight: 200, | ||
width: '100%', | ||
width: 150, | ||
offsetLeft: 20, | ||
single: true | ||
}; | ||
|
||
|
@@ -130,16 +138,17 @@ export class SingleSelectEditor implements Editor { | |
this.collection = this.columnDef.params.collection || []; | ||
this.labelName = (this.columnDef.params.customStructure) ? this.columnDef.params.customStructure.label : 'label'; | ||
this.valueName = (this.columnDef.params.customStructure) ? this.columnDef.params.customStructure.value : 'value'; | ||
const isEnabledTranslate = (this.columnDef.params.enableTranslateLabel) ? this.columnDef.params.enableTranslateLabel : false; | ||
|
||
let options = ''; | ||
this.collection.forEach((option: SelectOption) => { | ||
if (!option || (option[this.labelName] === undefined && option.labelKey === undefined)) { | ||
throw new Error('A collection with value/label (or value/labelKey when using ' + | ||
'Locale) is required to populate the Select list, for example: ' + | ||
'{ collection: [ { value: \'1\', label: \'One\' } ])'); | ||
'Locale) is required to populate the Select list, for example: { params: { ' + | ||
'{ collection: [ { value: \'1\', label: \'One\' } ] } } }'); | ||
} | ||
const labelKey = (option.labelKey || option[this.labelName]) as string; | ||
const textLabel = labelKey; | ||
const textLabel = ((option.labelKey || isEnabledTranslate) && this._i18n && typeof this._i18n.tr === 'function') ? this._i18n.tr(labelKey || ' ') : labelKey; | ||
|
||
options += `<option value="${option[this.valueName]}">${textLabel}</option>`; | ||
}); | ||
|
@@ -161,14 +170,15 @@ export class SingleSelectEditor implements Editor { | |
const elementOptions = (this.columnDef.params) ? this.columnDef.params.elementOptions : {}; | ||
const options: MultipleSelectOption = { ...this.defaultOptions, ...elementOptions }; | ||
this.$editorElm = this.$editorElm.multipleSelect(options); | ||
setTimeout(() => this.$editorElm.multipleSelect('open')); | ||
} | ||
} | ||
|
||
// refresh the jquery object because the selected checkboxes were already set | ||
// prior to this method being called | ||
private refresh() { | ||
if (typeof this.$editorElm.multipleSelect === 'function') { | ||
this.$editorElm.data('multipleSelect').refresh(); | ||
this.$editorElm.multipleSelect('refresh'); | ||
} | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this will probably fail at Build,
args
could possibly be undefined here