Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow using AureliaSlickgrid component w/o grid options #1298

Merged
merged 1 commit into from
Dec 11, 2024

Conversation

ghiscoding
Copy link
Owner

@ghiscoding ghiscoding commented Dec 11, 2024

  • we should be able to use Aurelia-Slickgrid custom element without providing any grid options

Copy link

stackblitz bot commented Dec 11, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

codecov bot commented Dec 11, 2024

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 20.91%. Comparing base (b59bf34) to head (3a1cf85).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...slickgrid/src/custom-elements/aurelia-slickgrid.ts 0.00% 5 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1298   +/-   ##
=======================================
  Coverage   20.91%   20.91%           
=======================================
  Files           8        8           
  Lines         952      952           
  Branches      350      327   -23     
=======================================
  Hits          199      199           
  Misses        753      753           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ghiscoding ghiscoding force-pushed the feat/grid-options-not-required branch from 631aa66 to 3a1cf85 Compare December 11, 2024 03:56
@ghiscoding ghiscoding merged commit 0345ecd into master Dec 11, 2024
3 of 4 checks passed
@ghiscoding ghiscoding deleted the feat/grid-options-not-required branch December 11, 2024 04:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant