Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: option to improve Date Sorting by pre-parsing date items only once #1268

Merged
merged 2 commits into from
Sep 29, 2024

Conversation

ghiscoding
Copy link
Owner

No description provided.

Copy link

stackblitz bot commented Sep 29, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

codecov bot commented Sep 29, 2024

Codecov Report

Attention: Patch coverage is 0% with 8 lines in your changes missing coverage. Please review.

Project coverage is 21.40%. Comparing base (64f3cb2) to head (10f7e27).
Report is 8 commits behind head on master.

Files with missing lines Patch % Lines
...slickgrid/src/custom-elements/aurelia-slickgrid.ts 0.00% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1268      +/-   ##
==========================================
- Coverage   21.56%   21.40%   -0.15%     
==========================================
  Files           8        8              
  Lines         937      944       +7     
  Branches      324      348      +24     
==========================================
  Hits          202      202              
- Misses        735      742       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ghiscoding ghiscoding merged commit 3161d98 into master Sep 29, 2024
3 of 4 checks passed
@ghiscoding ghiscoding deleted the perf/improve-date-sorting-speed branch September 29, 2024 04:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant