Skip to content
This repository has been archived by the owner on Jul 1, 2020. It is now read-only.

Changes to alpha* and euro date #41

Merged
merged 2 commits into from
Jun 24, 2015
Merged

Conversation

cwallervand
Copy link
Contributor

Alpha validations now allows æ, Æ, ø and Ø.
Euro date now allows . as a seperator, e.g. 15.10.97

@ghiscoding
Copy link
Owner

Thanks for the addition, I will look it up tonight and update my Protractor tests to cover the changes before creating another version. I should probably add the dot notation for US format too.

ghiscoding added a commit that referenced this pull request Jun 24, 2015
Changes to alpha* and euro date
@ghiscoding ghiscoding merged commit fa6f7c3 into ghiscoding:master Jun 24, 2015
@ghiscoding
Copy link
Owner

Good think I looked into updating my Protractor tests because you made an error in the date format. You cannot put your Regex as this [.-/] because the - in the middle is now interpreted as a range meaning you start with . and end with / and this is failing my tests badly since after your changes the - is not longer working. It took me a few minutes to find out what was happening, but not a major problem, the proper way to write it is [-/.], just by making the - as the first character is enough to exclude it from being a range.

I'm updating my code in consequence and will push a new revision once I'm done with Protractor tests :)

ghiscoding added a commit that referenced this pull request Jun 24, 2015
- Merge pull request #41 and fixed some errors found inside it.
- Updated Protractor tests
@ghiscoding
Copy link
Owner

Alright it's all good now.. if you like the project, you can click on the Star

Thanks for the help :)

ghiscoding added a commit that referenced this pull request Jun 24, 2015
- Merge pull request #41 and fixed some errors found inside it.
- Updated Protractor tests
@cwallervand
Copy link
Contributor Author

Damn, sorry for causing bugs :/ I was looking for some jasmine tests or some such in the project, but didnt find any so I didnt know how to test it...havent used Protractor before.

@ghiscoding
Copy link
Owner

No problem, that is what the tests are for.. :)
Enjoy it, use it, make it your favorite

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants