This repository has been archived by the owner on Jul 1, 2020. It is now read-only.
Added norwegian translation and changes to allow user to remove invalid validators #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update from original
Easter holiday, cant keep this code locked up in the office for a week...
Added norwegian translation, and added a new key: INVALID_REQUIREDSELECTION. French and spanish have not been translated for new key.
This reverts commit 988be73.
This reverts commit 32cc8a0.
Added norwegian language translation
Fixes for removing invalid validation re. wizard
tlastad
changed the title
|
Ok, this pull request got a little more than I thought :)
If this isn't what you want, let me know :) |
If validationError has been mistyped, the code will not find requested element. It will then just append a new element as is standard functionality. But it will never try to find the added element if it revalidates, and add a new message for each validation. This should fix that problem
ghiscoding
added a commit
that referenced
this pull request
Apr 8, 2015
Added norwegian translation and changes to allow user to remove invalid validators
|
Looks all good, I tried the Directive and Service and everything seems fine. I bumped the revision to v1.3.14 in case you use Bower :) How is the rest working for you? Hopefully it's more stable now, this project is becoming much bigger than I imagined but I think it's worth it, there is a lot of nice features now :) Thanks for the translation as well, always nice to see different nationalities can use this great project. Oh and did you have a chance to try the alternate text on validators? How do you like it? |
|
It all works good. We're really happy with it :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added norwegian translation file