Skip to content
This repository has been archived by the owner on Jul 1, 2020. It is now read-only.

in_list: doesn't work well with symbols #96

Closed
lwj5 opened this issue Dec 14, 2015 · 4 comments
Closed

in_list: doesn't work well with symbols #96

lwj5 opened this issue Dec 14, 2015 · 4 comments

Comments

@lwj5
Copy link

lwj5 commented Dec 14, 2015

An example here: http://plnkr.co/edit/Rwupj91yWAbfgsgIebsb

Try to validate your blood type. "A" passes validation while, "A+" fails. Along with other text that have symbols. The feature seems to truncate symbols.

@ghiscoding
Copy link
Owner

I was using \b in my RegExp, which is Word Boundary. This unfortunately means that only words are excepted, which excludes special characters and that explains why the A was valid while the A+ was invalid.

I also found out that I don't actually need to use word boundaries, I can simply use it directly in my RegExp ^(word1|word2|A\+)$, as long as the string is also escaped.

I will push the fix in the next revision, sometime this week. Thanks for the feedback

You live in Singapore? It's nice there, been there twice, wouldn't mind to live there, better than Canadian winter hehe

ghiscoding added a commit that referenced this issue Dec 15, 2015
Fixed issue #92 input name with '.' was not working correctly on error
message
Issue #96 in_list was not accepting special characters.
Enhancement #94 added Polish characters, thanks @Waniusza
@ghiscoding
Copy link
Owner

This was fixed in last release v1.4.17

@lwj5
Copy link
Author

lwj5 commented Dec 17, 2015

@ghiscoding I see, thanks for the really fast fix.

Yea, I live in Singapore! Canadian winter is just freezing cold, but It's gets pretty hot down here. For me, I would definitely like to go to a colder country! haha

I guess the grass is always greener on the other side eh. Cheers!

@ghiscoding
Copy link
Owner

Haha you're right, I don't mind the warm weather but I actually find that the humidity is a bit too high in Singapore. Canadian summer is nice, if only it could be all year haha.

Thanks for the feedback, enjoy the package and tell your friends ;)
I'll let you know next time I go back to SG, hotel is near NUS university on Bencoolen street.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants