-
Notifications
You must be signed in to change notification settings - Fork 58
Regex problem with / #63
Comments
Oh ok, it seems that my code is wrong and is pulling the code up to the first |
Custom Regex pattern was non-greedy and was causing problem when user had a '/' inside his own custom pattern.
Ok I fixed it, my own code was non-greedy and it was grabbing until it found the first '/' and that was the problem, so I just had to make it greedy and now it looks all fine. I only tried it via https://regex101.com/ and it seems fine now, see the print screen below. If you still have an issue then let me know and I will re-open it, if need be... |
Well, I already tested it and it seems to work like a charm. Thanks a lot! If anything goes wrong, I'll tell you. By the way, I noticed there are some words into Spanish language file (es.json) that are wrong or need some diacritical marks. If you want, I could help you with that and make you a pull request. ;) |
Oh yes go ahead and make a new pull request for the wrong Spanish words. Thanks for the feedback |
Hi. First at all thanks for this great package. It has saved my life.
Going right to the point, I was trying to use 'pattern' option to allow slashes but it throws an error and cuts the expression. For example:
The error says:
I'm using backslash to escape slash into the expression. But the slash inside is cutting the expression and doesn't recognize the escaping.
Is there anyway to fix this, please? or In which way could I extend the service or something in order to add a new regular expression but without passing it as string?
Sorry for my bad english. Thanks in advance.
The text was updated successfully, but these errors were encountered: