unbind 'blur' in cancelValidation()

[LennyLip]

I think, obj.commonObj.elm.unbind('blur'); in cancelValidation() is wrong.

FE, I have a angular-strap tooltip, which triggered on blur event. When i have input field with validation="max_len:50" and empty value when lost focus blur does not work and tooltip does not disappear, because blur is unbind.

[ghiscoding]

The biggest reason of the cancelValidation() is that I don't want to annoy the user on an empty form, not doing this would mean showing all errors directly at start, which is the reason of the cancelValidation()

You should perhaps try using the checkFormValidity(), that would trigger all the errors while also checking the form validity. If that is not what you are trying to do, then I might have misunderstood your question.

[ghiscoding]

Also by the way, the error messages are only showing if the element is $dirty, $touched or if the form has been submitted.

[LennyLip]

Ok, i've created http://plnkr.co/edit/x6AI9U8mGF0P4NMVmzvR?p=preview

see second input , tooltip does not disappear, because blur is unbind by cancelValidation(). but in first input all ok, because "required".

[LennyLip]

i've beenn updated this comment

@ghiscoding
you wrote "// unbind onBlur event, if not it will fail when input become dirty & empty"

I could be wrong, but may be we can something like: add "watch" and when input empty set $setPristine(); for input.

?

I think unbind 'blur' too radical decision, that affects other modules

[ghiscoding]

This should fix it...

[LennyLip]

it is does not helped, see http://plnkr.co/edit/x6AI9U8mGF0P4NMVmzvR?p=preview with 1.3.19
may be its angular-strap issue?

[ghiscoding]

Well I am not doing a full unbind anymore so I don't think it comes from my end, you could even remove the unbind from my code and it would still work. Try debugging it and see what can cause it... If you want to debug my code, you should use the non-minified versions.

[LennyLip]

i h've been commented this line and tooltip is disappeared.

//elm.unbind('blur', blurHandler); // unbind onBlur event so that it does not fail on a non-required element that is now dirty & empty

also, i don't have any "fail on a non-required element that is now dirty & empty" (with dirty & empty input).

[LennyLip]

hm, i've been debug
elm.unbind('blur', blurHandler);

and i see, that blurHandler is undefined. (thats why ubnind disable all blur handlers)/

i think, it because cancelValidation() run before elm.bind.

[ghiscoding]

it is not suppose to be undefined, it's a global variable and is set at the bind calling, unless it's unset on first pass. You could try commenting out that line (unbind) and see if that really is your problem. I still need to unbind it somehow because I might end up with 50 calls at the end.

[LennyLip]

validation-directive.js
we have "elm.bind('blur', blurHandler = function() {" on 85 line, but "cancelValidation();" is call on 72 line in one function "function attemptToValidate(value) {".

so, we call "elm.unbind('blur', blurHandler); " with undefined blurHandler.

http://savepic.net/6756572.png

[LennyLip]

You could try commenting out that line (unbind) and see if that really is your problem.

it's really my problem
#28 (comment)

[ghiscoding]

Could you try the following

// replace this line
elm.unbind('blur', blurHandler);

// with these lines
if(typeof blurHandler !== "undefined") {
  elm.unbind('blur', blurHandler);
}

I am at work and I cannot really test it, it would help if you can test it with your code too.

[LennyLip]

@ghiscoding
seems, it is works, thank you!

[ghiscoding]

Ok I will make more tests tonight and will also fix another open issue at the same time. You should expect to see the new code and the minified code on the next version 1.3.20 later tonight.

Thanks

[ghiscoding]

As promised, I push the code after testing... Hopefully that works for you