-
Notifications
You must be signed in to change notification settings - Fork 58
angularValidation.revalidate problems #150
Comments
Latest version is Try with latest version just to see |
I was on 1.5.18 when I noticed it, I narrowed it down to the 1.5.13 change (I think) I think it's this in validation-directive.js scope.$on('angularValidation.revalidate', function(event, args){
if (args == ctrl.$name)
{
ctrl.revalidateCalled = true;
var value = ctrl.$modelValue;
if (!!elm && elm.hasOwnProperty("isValidationCancelled")) {
// attempt to validate & run validation callback if user requested it
var validationPromise = attemptToValidate(value);
if(!!_validationCallback) {
commonObj.runValidationCallbackOnPromise(validationPromise, _validationCallback);
}
}
else {
ctrl.$setValidity('validation', true);
}
}
}); elm.hasOwnProperty("isValidationCancelled") doesn't seem to ever evaluate to true. I'm not 100% sure, but I think elm is wrong type of thing to be evaluating, that other parts of the code are setting that property on a different object. |
What I suggest you to do is to debug it using the plunker sample you got and use Thanks for the help |
Thanks to @jsolt for fixing the issue
New release v1.5.19 pushed with your fix. Thanks again for the contribution :) |
Awesome, thanks for the super quick turnaround, now we're up to the latest version again :) |
I'm having a problem using angularValidate.revalidate.
It looks like the change introduced in v1.5.13 broke it, because if I switch back to 1.5.12 it works.
I used the punker in the wiki: http://plnkr.co/o1fftbnmRfjScEDmi7ZH?p=preview and it works, but it's got the old code. If I copied the most recent code in it stops working.
The text was updated successfully, but these errors were encountered: