Skip to content
This repository has been archived by the owner on Jul 1, 2020. It is now read-only.

Grunt warning with uppercase #107

Closed
Naimikan opened this issue Feb 2, 2016 · 2 comments
Closed

Grunt warning with uppercase #107

Naimikan opened this issue Feb 2, 2016 · 2 comments

Comments

@Naimikan
Copy link
Contributor

Naimikan commented Feb 2, 2016

When I run grunt, throws me the following warning:

A constructor name Should start with an uppercase letter.

In the line where I do:

if (new validationService().checkFormValidity($scope.formRegister)) { // ... }

I think if validationService is a class should be capitalize

@ghiscoding
Copy link
Owner

Unfortunately it's a bad decision that I have to stick with. I can't just come and change it since I would make a 140+ users pissed at me if all of a sudden 1 of the very often used Service is change.

This typo would break a lot of people's code and I surely don't want that. I realized that I made a mistake long time ago but it's just too late in the game to fix it.

Thanks anyway

ghiscoding added a commit that referenced this issue Feb 24, 2016
- new 1.5.x branch has a breaking change, which is the fix of the
uppercase on ValidationService object (instead of validationService
which was wrong has mentioned in issue #107).
- added angular-validation-ghiscoding to NPM and fixed the .npmignore
@ghiscoding
Copy link
Owner

Finally decided to bite the bullet and fix it under a major 1.5.x branch
See Revision 1.5.0

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants