Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(addon): providing columnIndexPosition should always work #794

Merged
merged 1 commit into from
Jun 17, 2021

Conversation

ghiscoding
Copy link
Owner

  • providing columnIndexPosition should work regardless of when the extension (plugin) is created, basically the previous code was assuming that you will always want the checkbox before the row move plugin but that is not always true and the other way around wasn't possible while this PR fixes it

- providing columnIndexPosition should work regardless of when the extension (plugin) is created, basically the previous code was assuming that you will always want the checkbox before the row move plugin but that is not always true and the other way around wasn't possible while this PR fixes it
@codecov
Copy link

codecov bot commented Jun 17, 2021

Codecov Report

Merging #794 (4ff9935) into master (5660240) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #794   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          162       162           
  Lines        11325     11340   +15     
  Branches      3983      3884   -99     
=========================================
+ Hits         11325     11340   +15     
Impacted Files Coverage Δ
...es/angular-slickgrid/services/extension.service.ts 100.00% <100.00%> (ø)
...es/angular-slickgrid/services/gridState.service.ts 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5660240...4ff9935. Read the comment docs.

@ghiscoding ghiscoding merged commit 1bb0358 into master Jun 17, 2021
@ghiscoding ghiscoding deleted the bugfix/preserve-extension-column-index-position branch June 17, 2021 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant