Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(backend): GraphQL queries with input filter #659

Merged
merged 1 commit into from
Jan 5, 2021

Conversation

ghiscoding
Copy link
Owner

  • Improved escaping/normalizing search terms for string/text/readonly fields.
  • Invalid characters from integer/float/number fields with string search terms are now removed.
  • Added support for range filter .. to function without an upper bound. When for example 2.. is input then field GE 2 or field GT 2 is send to the backend, depending on the defaultFilterRangeOperator
  • Added support for range filter .. to function without a lower bound. When for example ..2 is input field LE 2 or field LT 2 is send, depending on the defaultFilterRangeOperator

* Improved escaping/normalizing search terms for string/text/readonly fields.
* Invalid characters from integer/float/number fields with string search terms are now removed.
* Added support for range filter `..` to function without an upper bound. When for example `2..` is input then `field GE 2` or `field GT 2` is send to the backend, depending on the `defaultFilterRangeOperator`
* Added support for range filter `..` to function without a lower bound. When for example `..2` is input `field LE 2` or `field LT 2` is send, depending on the `defaultFilterRangeOperator`
- ref issue #656
@codecov
Copy link

codecov bot commented Jan 5, 2021

Codecov Report

Merging #659 (8465610) into master (48b4ebc) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##            master      #659    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files          154       154            
  Lines        10397     10433    +36     
  Branches      3513      3684   +171     
==========================================
+ Hits         10397     10433    +36     
Impacted Files Coverage Δ
...ules/angular-slickgrid/services/graphql.service.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 48b4ebc...8465610. Read the comment docs.

@ghiscoding ghiscoding merged commit 0ae6363 into master Jan 5, 2021
@ghiscoding ghiscoding deleted the bugfix/graphql-range-filter branch January 5, 2021 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant