Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grid filter is showing blank spaces for unmatched records. #865

Closed
roopeshkurian opened this issue Dec 15, 2021 · 5 comments
Closed

Grid filter is showing blank spaces for unmatched records. #865

roopeshkurian opened this issue Dec 15, 2021 · 5 comments

Comments

@roopeshkurian
Copy link

I'm submitting a Bug report

Your Environment

Software Version(s)
Angular 13.1
Angular-Slickgrid 4.0
TypeScript 4.5

Describe the Bug

One of your example https://ghiscoding.github.io/Angular-Slickgrid/#/graphql-nopage
Native column I am typing b. I could see blank spaces for unmatched records.

Steps to Reproduce

Please go to https://ghiscoding.github.io/Angular-Slickgrid/#/graphql-nopage
in the Native column type b or some other letters.

Expected Behavior

Currently you set label display none. But may be you need to set li to display none.

Current Behavior

Blank spaces are coming for unmatched records.

Possible Solution

Currently you set label display none when its not matching. But may be you need to set li to display none.

Code Sample

https://ghiscoding.github.io/Angular-Slickgrid/#/graphql-nopage

image

ghiscoding added a commit to ghiscoding/slickgrid-universal that referenced this issue Dec 16, 2021
- fixes Angular-Slickgrid issue [#865](ghiscoding/Angular-Slickgrid#865)
- recent commit to add multiple-select fixed height (with variable `slick-multiselect-item-height`) conflicted with multiple-select styling since that external lib only changed the child <label> display, while in fact it should be hiding its <li> parent, this is now exactly what the new version of multiple-select does
- also update few npm packages
@ghiscoding
Copy link
Owner

ghiscoding commented Dec 16, 2021

This is indirectly caused by a new CSS/SASS variable $slick-multiselect-item-height that I added recently, however I don't think removing that variable is necessarily the best solution. The real issue is because multiple-select.js external lib shows these dropdown options in elements like this <li><label>Option 1</label><input type="checkbox"/></li> and instead of hiding the <li> they're hiding the <label>, which is not ideal. Fortunately I have my own fork of multiple-select.js to make it work better with SlickGrid, so I went and updated multiple-select-modified lib, released a new version for it and then updated the NPM package in this Slickgrid-Universal PR #581, but I probably won't release a new version until couple more weeks.

Kind of a long explanation, but on the short side there's actually a temporary solution, you can implement.
You can do it by changing the CSS or SASS variable

/* SASS */
$slick-multiselect-item-height: inherit;

/* or CSS Variable */ 
:root {
  --slick-multiselect-item-height: none;
}

@roopeshkurian
Copy link
Author

Thank you for providing a temporary solution. It worked for me.
Keep up the good work.
Thank you for this wonderful grid and new updates.

@ghiscoding
Copy link
Owner

By the way, since I've fixed the issue in the external lib multiple-select-modified you could get the fix but you might need to delete your npm or yarn lock file and re-run npm install would get you the latest version of that lib.

@roopeshkurian
Copy link
Author

Deleted npm and tried again. It worked. Thanks for your help

@ghiscoding
Copy link
Owner

ghiscoding commented Jan 6, 2022

@roopeshkurian
I can now close this since it got officially fixed by today's Release version 4.1.0 with updated version of Slickgrid-Universal

Cheers and thanks for the feedback ⭐

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants