-
-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Grid filter is showing blank spaces for unmatched records. #865
Comments
- fixes Angular-Slickgrid issue [#865](ghiscoding/Angular-Slickgrid#865) - recent commit to add multiple-select fixed height (with variable `slick-multiselect-item-height`) conflicted with multiple-select styling since that external lib only changed the child <label> display, while in fact it should be hiding its <li> parent, this is now exactly what the new version of multiple-select does - also update few npm packages
This is indirectly caused by a new CSS/SASS variable Kind of a long explanation, but on the short side there's actually a temporary solution, you can implement. /* SASS */
$slick-multiselect-item-height: inherit;
/* or CSS Variable */
:root {
--slick-multiselect-item-height: none;
}
|
Thank you for providing a temporary solution. It worked for me. |
By the way, since I've fixed the issue in the external lib multiple-select-modified you could get the fix but you might need to delete your npm or yarn lock file and re-run npm install would get you the latest version of that lib. |
Deleted npm and tried again. It worked. Thanks for your help |
@roopeshkurian Cheers and thanks for the feedback ⭐ |
I'm submitting a Bug report
Your Environment
Describe the Bug
One of your example https://ghiscoding.github.io/Angular-Slickgrid/#/graphql-nopage
Native column I am typing b. I could see blank spaces for unmatched records.
Steps to Reproduce
Please go to https://ghiscoding.github.io/Angular-Slickgrid/#/graphql-nopage
in the Native column type b or some other letters.
Expected Behavior
Currently you set label display none. But may be you need to set li to display none.
Current Behavior
Blank spaces are coming for unmatched records.
Possible Solution
Currently you set label display none when its not matching. But may be you need to set li to display none.
Code Sample
https://ghiscoding.github.io/Angular-Slickgrid/#/graphql-nopage
The text was updated successfully, but these errors were encountered: