-
-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Header Scroll position reset after column reorder #297
Comments
No idea but this is not an issue with Angular-Slickgrid, rather an issue with the core library SlickGrid, you should search the issues there and maybe also check Stack Overflow. |
I tried the same example with both SlickGrid and Slick Angular, it's working fine in the slick grid , Try with those 2 examples : The same thing with add column working fine for slickGrid but not for angular SlickGrid |
I cannot see and understand what you mean, can you make an animated gif (I use ShareX) or at least a print screen. The basic grid has fixed height/width. |
Ok This one from |
Sorry but even if I try on my side, I cannot replicate that behavior. Are you using IE11 by any chance? It seems to be all good in Chrome |
I just tried it with chrome it's working, but with firefox and IE it's not. |
You need polyfill for IE, but even then I don't want to support IE since it will be end of life by year end. As for Firefox, it should work but again this issue has to come for the core library, I'm not handling that portion (drag & drop of a column). Angular-Slickgrid is just a wrapper on top of the core lib. I'd be surprised the issue coming from my lib instead of the core, though I can't explain why the core doesn't show the issue EDIT |
I see your point, but as I told you in the example it works fine with SlickGrid using firefox but not with Angular-Slickgrid. |
Unfortunately, I don't have the time to look into this. I'm already trying to finish up all the unit testing and I have no cycle to look into this. |
@slayer303 You can see a before/after in PR #300. I just released a new version of the lib couple of hours ago but I could push a patch version in the coming days. You could also patch it yourself in your code to see if the fix works in your grid. You will need to change your styling encapsulation to .slickgrid-container {
.slick-header-columns,
.slick-header-column {
box-sizing: content-box !important; /* this here only for Firefox! */
}
} |
Thanks so much, it's working correctly! It also works for IE. |
It also fixes the second issue about adding a new column without losing the scroll bar position of the header. |
…ing-styling-issue fix(styling): styling issue in Firefox after col reordering, fixes #297
@slayer303 Cheers ⭐️ |
Hi,
I have 10 columns in my grid a horizontal scroll is shown, when I scroll right then try to reorder some columns this cause gird misaligned with the header.
I have another issue related to misalignment, I want to add new column to the grid without losing horizontal scroll position is that possible ? Because when I use grid.setColumns(columns) or of course this.columnDefinitions = columns , the header scroll bar is reset while the grid data still
at the same place.
Let me know if you have any idea for fix that.
Thanks for your Grid it was really very helpful
Cheers
The text was updated successfully, but these errors were encountered: