-
-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
can't access property "length", a.sharedService.visibleColumns is undefined
when hiding column
#1180
Comments
The issue does not show up if you refresh the page, it only shows when coming from another page. So there's probably some leaking somewhere of something that wasn't disposed or destroyed before routing to another page. It seems to point to SortableJS code throwing and the error comes from this line in the SortableJS github code Also probably related to this other SortableJS issue and a user also mentioned SlickGrid as well in that issue |
- this fixes 2 issues identified in Angular-Slickgrid, ghiscoding/Angular-Slickgrid#1180 - when leaving a SPA page and going back to it, it could throw a bunch of errors. We simply need to make sure that any sortable instances are destroyed before recreating any new ones
- this fixes 2 issues identified in Angular-Slickgrid, ghiscoding/Angular-Slickgrid#1180 - when leaving a SPA page and going back to it, it could throw a bunch of errors. We simply need to make sure that any sortable instances are destroyed before recreating any new ones
…rtable-errors fix(grouping): DraggableGrouping could throw when leaving page, fixes #1180
fixed in v6.0.1 |
you could also star the project if you like the lib 😉 ⭐ Cheers |
Describe the bug
The error
can't access property "length", a.sharedService.visibleColumns is undefined
is printed to the console, after moving a column, and then hiding one of the columns.Reproduction
Expectation
No error should be thrown.
Environment Info
Environment: https://ghiscoding.github.io/Angular-Slickgrid/#/draggrouping Browser: Firefox / Chrome OS: Windows 11
Validations
The text was updated successfully, but these errors were encountered: