Code review rework

ghiscoding · Jan 5, 2021 · d9aab76 · d9aab76
1 parent ded54d9
commit d9aab76
Showing 1 changed file with 5 additions and 5 deletions.
diff --git a/src/app/modules/angular-slickgrid/services/__tests__/grid-odata.service.spec.ts b/src/app/modules/angular-slickgrid/services/__tests__/grid-odata.service.spec.ts
@@ -1610,7 +1610,7 @@ describe('GridOdataService', () => {
         expect(query).toBe(expectation);
       });
 
-      it('should return a query to filter a search value with a number that contains invalid characters', () => {
+      it('should return a query without invalid characters to filter a search value with a number that contains invalid characters', () => {
         const expectation = `$filter=(Duration eq -22)`;
         const mockColumnDuration = { id: 'duration', field: 'duration', type: FieldType.number } as Column;
         const mockColumnFilters = {
@@ -1624,9 +1624,9 @@ describe('GridOdataService', () => {
         expect(query).toBe(expectation);
       });
 
-      it('should return a query to filter a search value with an integer that contains invalid characters', () => {
+      it('should return a query without invalid characters to filter a search value with an integer that contains invalid characters', () => {
         const expectation = `$filter=(Duration eq 22)`;
-        const mockColumnDuration = { id: 'duration', field: 'duration', type: FieldType.number } as Column;
+        const mockColumnDuration = { id: 'duration', field: 'duration', type: FieldType.integer } as Column;
         const mockColumnFilters = {
           duration: { columnId: 'duration', columnDef: mockColumnDuration, searchTerms: ['22;'] },
         } as ColumnFilters;
@@ -1638,9 +1638,9 @@ describe('GridOdataService', () => {
         expect(query).toBe(expectation);
       });
 
-      it('should return a query to filter a search value with a number that only has a minus characters', () => {
+      it('should return a query with 0 to filter a search value when the search value contains a minus', () => {
         const expectation = `$filter=(Duration eq 0)`;
-        const mockColumnDuration = { id: 'duration', field: 'duration', type: FieldType.number } as Column;
+        const mockColumnDuration = { id: 'duration', field: 'duration', type: FieldType.float } as Column;
         const mockColumnFilters = {
           duration: { columnId: 'duration', columnDef: mockColumnDuration, searchTerms: ['-'] },
         } as ColumnFilters;