don't report expressions with Nothing type

ghik · Nov 18, 2022 · 6b14a44 · 6b14a44
1 parent d3c7b59
commit 6b14a44
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 2 deletions.
diff --git a/src/main/scala-3/com/github/ghik/zerowaste/ZerowastePlugin.scala b/src/main/scala-3/com/github/ghik/zerowaste/ZerowastePlugin.scala
@@ -42,7 +42,7 @@ class ZerowastePhase extends PluginPhase {
   }
 
   private def notUnit(tree: Tree)(using Context): Boolean =
-    !(tree.tpe =:= defn.UnitType)
+    !(tree.tpe <:< defn.UnitType)
 
   private def report(tree: Tree)(using Context): Unit =
     dotty.tools.dotc.report.warning("discarded expression with non-Unit value", tree.srcPos)

diff --git a/src/test/scala-3/com/github/ghik/zerowaste/ZerowastePluginTest.scala b/src/test/scala-3/com/github/ghik/zerowaste/ZerowastePluginTest.scala
@@ -1,11 +1,11 @@
 package com.github.ghik.zerowaste
 
-import org.scalatest.funsuite.AnyFunSuite
 import dotty.tools.dotc.Compiler
 import dotty.tools.dotc.core.Contexts.*
 import dotty.tools.dotc.plugins.Plugin
 import dotty.tools.io.{Path, PlainFile}
 import org.scalactic.source.Position
+import org.scalatest.funsuite.AnyFunSuite
 
 class ZerowastePluginTest extends AnyFunSuite {
   val compiler = new Compiler

diff --git a/testdata/zerowaste.scala b/testdata/zerowaste.scala
@@ -29,6 +29,8 @@ object zerowaste {
   }
 
   // should not emit warnings
+  throw new Exception("nienie")
+
   val t = com.github.ghik.zerowaste.Macro.inlinedValue // macro
 
   class Klas(arg: Int) {