Skip to content

Commit

Permalink
*: improve executor to make test faster (pingcap#41442)
Browse files Browse the repository at this point in the history
  • Loading branch information
hawkingrei authored and ghazalfamilyusa committed Feb 15, 2023
1 parent f7bb8b2 commit 1f9f8c0
Show file tree
Hide file tree
Showing 6 changed files with 91 additions and 2 deletions.
1 change: 0 additions & 1 deletion expression/BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -172,7 +172,6 @@ go_test(
"expression_test.go",
"function_traits_test.go",
"helper_test.go",
"integration_serial_test.go",
"main_test.go",
"multi_valued_index_test.go",
"scalar_function_test.go",
Expand Down
31 changes: 31 additions & 0 deletions expression/integration_serial_test/BUILD.bazel
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
load("@io_bazel_rules_go//go:def.bzl", "go_test")

go_test(
name = "integration_serial_test_test",
timeout = "short",
srcs = [
"integration_serial_test.go",
"main_test.go",
],
flaky = True,
shard_count = 50,
deps = [
"//config",
"//parser/mysql",
"//parser/terror",
"//planner/core",
"//session",
"//sessionctx/variable",
"//testkit",
"//testkit/testmain",
"//testkit/testsetup",
"//types",
"//util/timeutil",
"@com_github_pingcap_errors//:errors",
"@com_github_pingcap_failpoint//:failpoint",
"@com_github_stretchr_testify//require",
"@com_github_tikv_client_go_v2//oracle",
"@com_github_tikv_client_go_v2//tikv",
"@org_uber_go_goleak//:goleak",
],
)
3 changes: 3 additions & 0 deletions expression/integration_serial_test/README.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
Too many test case in this package.

Please not add new test cases in this package.
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
// See the License for the specific language governing permissions and
// limitations under the License.

package expression_test
package integration_serial_test

import (
"context"
Expand Down
53 changes: 53 additions & 0 deletions expression/integration_serial_test/main_test.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,53 @@
// Copyright 2023 PingCAP, Inc.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.

package integration_serial_test

import (
"testing"

"github.com/pingcap/tidb/config"
"github.com/pingcap/tidb/testkit/testmain"
"github.com/pingcap/tidb/testkit/testsetup"
"github.com/pingcap/tidb/util/timeutil"
"github.com/tikv/client-go/v2/tikv"
"go.uber.org/goleak"
)

func TestMain(m *testing.M) {
testsetup.SetupForCommonTest()
testmain.ShortCircuitForBench(m)

config.UpdateGlobal(func(conf *config.Config) {
conf.TiKVClient.AsyncCommit.SafeWindow = 0
conf.TiKVClient.AsyncCommit.AllowedClockDrift = 0
conf.Experimental.AllowsExpressionIndex = true
})
tikv.EnableFailpoints()

// Some test depends on the values of timeutil.SystemLocation()
// If we don't SetSystemTZ() here, the value would change unpredictable.
// Affected by the order whether a testsuite runs before or after integration test.
// Note, SetSystemTZ() is a sync.Once operation.
timeutil.SetSystemTZ("system")

opts := []goleak.Option{
goleak.IgnoreTopFunction("github.com/golang/glog.(*loggingT).flushDaemon"),
goleak.IgnoreTopFunction("github.com/lestrrat-go/httprc.runFetchWorker"),
goleak.IgnoreTopFunction("go.etcd.io/etcd/client/pkg/v3/logutil.(*MergeLogger).outputLoop"),
goleak.IgnoreTopFunction("go.opencensus.io/stats/view.(*worker).start"),
}

goleak.VerifyTestMain(m, opts...)
}
3 changes: 3 additions & 0 deletions expression/integration_test/README.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
Too many test case in this package.

Please not add new test cases in this package.

0 comments on commit 1f9f8c0

Please sign in to comment.