-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: resolve conflicting packages; address linting issues; resolve "@… #46
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,7 @@ | ||
<template> | ||
<slot /> | ||
<div> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. linting error complaining about having |
||
<slot /> | ||
</div> | ||
</template> | ||
<script lang="ts"> | ||
import { defineComponent, provide } from 'vue' | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -93,11 +93,13 @@ export default class Scale { | |
const valueMin: number = min(stackedData, (arr) => min(arr, (x) => min(x))) || 0 | ||
|
||
const [dataMin, dataMax] = extent(Array.from(new Set(values.concat([valueMin, valueMax])))) | ||
// eslint-disable-next-line no-eval | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. just ignoring these for now: my recommendation would be to allow a function to be passed through, rather than a string that you have to |
||
const yMin = eval(` | ||
let dataMin = ${dataMin || 0} | ||
${domain[0]} | ||
`) | ||
|
||
// eslint-disable-next-line no-eval | ||
const yMax = eval(` | ||
let dataMax = ${dataMax || 0} | ||
${domain[1]} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
recommendation is to disable
no-unused-vars
as it complains about unused vars in interface declarations