Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pc98_config] Fix typo of capital Y #1882

Merged
merged 1 commit into from
Apr 18, 2024
Merged

Conversation

tyama501
Copy link
Contributor

Hello @ghaerr ,

It seems that the capital Y cannot read in the menuconfig.
CONFIG_APPS_BY_IMAGESZ=Y

One more thing,
if I use the menuconfig
CONFIG_EXEC_MMODEL duplicate. Why this happen?
image

Thank you.

@ghaerr
Copy link
Owner

ghaerr commented Apr 18, 2024

Oops, so much for my testing! Thank you @tyama501.

CONFIG_EXEC_MMODEL duplicate

I'm aware of this problem, but haven't figured a great way to fix it yet. It results from the forced definition in elks/fs/config.in:

    bool 'Support compressed executables'  CONFIG_EXEC_COMPRESS       y
    if [ "$CONFIG_EXEC_COMPRESS" == "y" ]; then
        define_bool CONFIG_EXEC_MMODEL y
    fi
    bool 'Support medium memory model'     CONFIG_EXEC_MMODEL         y

The define_bool is required to force CONFIG_EXEC_MMODEL when compressed executables are set, then apparently the bool in the next line sets it again.

I removed the second definition in the committed files because I was trying to keep the configuration files as simple as possible, rather than match make menuconfig output exactly. Perhaps that should change?

@ghaerr ghaerr merged commit e2eb23b into ghaerr:master Apr 18, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants