Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ToDo: diffs FF60-FF61 #426

Closed
8 tasks done
earthlng opened this issue May 19, 2018 · 15 comments
Closed
8 tasks done

ToDo: diffs FF60-FF61 #426

earthlng opened this issue May 19, 2018 · 15 comments

Comments

@earthlng
Copy link
Contributor

earthlng commented May 19, 2018

211 diffs ( 90 new, 101 gone, 20 different )

FF61 is scheduled for release 26-June

other

new in v61.0:

removed, renamed or hidden in v61.0:

  • pref("browser.storageManager.enabled", true); 1428306 - a4a9b9a
  • experiments 1450801 & 1420908 - 9386fb5
    • pref("experiments.enabled", true);
    • pref("experiments.manifest.uri", "https://telemetry-experiment.cdn.mozilla.net/manifest/v1/firefox/%VERSION%/%CHANNEL%");
    • pref("experiments.supported", true);
    • pref("experiments.activeExperiment", false);
  • remote jar 1427726 - 9386fb5
    • pref("network.jar.block-remote-files", true);
    • pref("network.jar.open-unsafe-types", false);
  • pref("services.blocklist.signing.enforced", true); 1397230 - a4a9b9a

changed in v61.0:

  • pref("browser.tabs.remote.warmup.enabled", true); // prev: false (FF57+) 1385453 - leaving up here for visibility
  • pref("privacy.usercontext.about_newtab_segregation.enabled", true); // prev: false 1703 (inactive)

ignore

click me for details

==NEW

pref("accessibility.monoaudio.enable", false);
pref("apz.android.chrome_fling_physics.enabled", false);
pref("apz.android.chrome_fling_physics.friction", "0.015");
pref("apz.android.chrome_fling_physics.inflexion", "0.35");
pref("apz.android.chrome_fling_physics.stop_threshold", "0.1");
pref("apz.max_tap_time", 300);
pref("browser.newtabpage.activity-stream.asrouterExperimentEnabled", false);
pref("browser.newtabpage.activity-stream.asrouter.snippetsUrl", "");
pref("browser.newtabpage.activity-stream.feeds.aboutpreferences", true);
pref("browser.newtabpage.activity-stream.feeds.asrouterfeed", true);
pref("browser.newtabpage.activity-stream.feeds.theme", true);
pref("browser.newtabpage.activity-stream.section.highlights.includeBookmarks", true);
pref("browser.newtabpage.activity-stream.section.highlights.includeDownloads", true);
pref("browser.newtabpage.activity-stream.section.highlights.includeVisited", true);
pref("browser.tabs.20FpsThrobber", false);
pref("browser.tabs.30FpsThrobber", false);
pref("browser.tabs.closeTabByDblclick", false);
pref("browser.tabs.insertAfterCurrent", false);
pref("devtools.accessibility.enabled", false);
pref("devtools.application.enabled", false);
pref("devtools.browserconsole.html", false);
pref("devtools.debugger.alphabetize-outline", false);
pref("devtools.debugger.component-stack-visible", true);
pref("devtools.debugger.component-visible", true);
pref("devtools.debugger.features.component-stack", false);
pref("devtools.debugger.features.pause-points", true);
pref("devtools.debugger.features.skip-pausing", false);
pref("devtools.debugger.skip-pausing", false);
pref("devtools.debugger.tabsBlackBoxed", "[]");
pref("devtools.inspector.fonteditor.enabled", false);
pref("devtools.inspector.show-three-pane-tooltip", false);
pref("devtools.inspector.three-pane-enabled", false);
pref("devtools.inspector.three-pane-toggle", false);
pref("devtools.netmonitor.responseBodyLimit", 1048576);
pref("devtools.netmonitor.saveRequestAndResponseBodies", true);
pref("devtools.toolbox.tabsOrder", "");
pref("dom.event.default_to_passive_touch_listeners", true);
pref("dom.indexedDB.storageOption.enabled", false);
pref("dom.performance.enable_scheduler_timing", false);
pref("dom.performance.time_to_dom_content_flushed.enabled", false);
pref("dom.use_components_shim", true);
pref("dom.vr.external.enabled", false);
pref("extensions.webcompat.perform_injections", true);
pref("extensions.webextensions.background-delayed-startup", false);
pref("gfx.downloadable_fonts.validate_variation_tables", true);
pref("gfx.webrender.async-scene-build", 2);
pref("gfx.webrender.blob.invalidation", true);
pref("gfx.webrender.dcomp-win.enabled", true);
pref("identity.fxaccounts.messages.enabled", false);
pref("intl.ime.hack.on_any_apps.fire_key_events_for_composition", false); // ANDROID IME-unaware apps
pref("layers.enable-tiles-if-skia-pomtp", false);
pref("layers.tiles.edge-padding", false);
pref("layers.tiles.retain-back-buffer", true);
pref("layout.css.emulate-moz-box-with-flex", false);
pref("layout.css.getPropertyCSSValue.enabled", false);
pref("layout.css.moz-document.url-prefix-hack.enabled", true);
pref("layout.css.parsing.parallel", true);
pref("marionette.contentListener", false);
pref("media.audio-max-decode-error", 3);
pref("media.av1.enabled", true);
pref("media.clearkey.persistent-license.enabled", false);
pref("media.eme.audio.blank", false);
pref("media.eme.video.blank", false);
pref("media.forcestereo.enabled", false);
pref("media.hls.enabled", false);
pref("media.mediasource.experimental.enabled", false);
pref("media.resampling.enabled", false);
pref("media.ruin-av-sync.enabled", false);
pref("media.videocontrols.lock-video-orientation", false);
pref("media.video-max-decode-error", 2);
pref("media.webaudio.audiocontextoptions-samplerate.enabled", true);
pref("media.webspeech.recognition.force_enable", false);
pref("media.webspeech.synth.force_global_queue", false);
pref("media.webspeech.test.enable", false);
pref("media.webspeech.test.fake_fsm_events", false);
pref("media.webspeech.test.fake_recognition_service", false);
pref("mousewheel.autodir.enabled", false);
pref("mousewheel.autodir.honourroot", false);
pref("network.cookie.move.interval_sec", 10);
pref("network.http.fallback-connection-timeout", 5);
pref("network.predictor.doing-tests", false); // 1448220 ?
pref("security.pki.mitm_canary_issuer", ""); // 1450967 ?
pref("security.pki.mitm_canary_issuer.enabled", true);
pref("security.sandbox.gmp.win32k-disable", false);
pref("services.settings.changes.path", "/buckets/monitor/collections/changes/records");
pref("services.settings.default_bucket", "main");
pref("services.settings.default_signer", "remote-settings.content-signature.mozilla.org");
pref("shield.savant.loglevel", "warn");

==REMOVED or HIDDEN

pref("apz.minimap.visibility.enabled", false);
pref("browser.newtabpage.activity-stream.collapseTopSites", false);
pref("browser.newtabpage.activity-stream.enableWideLayout", true);
pref("browser.newtabpage.activity-stream.section.highlights.collapsed", false);
pref("browser.newtabpage.activity-stream.section.topstories.collapsed", false);
pref("browser.newtabpage.activity-stream.showTopSites", true);
pref("browser.tabs.restorebutton", 0);
pref("devtools.browserconsole.filter.csserror", true);
pref("devtools.browserconsole.filter.csslog", false);
pref("devtools.browserconsole.filter.cssparser", false);
pref("devtools.browserconsole.filter.exception", true);
pref("devtools.browserconsole.filter.jslog", true);
pref("devtools.browserconsole.filter.jswarn", true);
pref("devtools.browserconsole.filter.netwarn", true);
pref("devtools.browserconsole.filter.network", true);
pref("devtools.browserconsole.filter.networkinfo", false);
pref("devtools.browserconsole.filter.secerror", true);
pref("devtools.browserconsole.filter.secwarn", true);
pref("devtools.browserconsole.filter.servererror", false);
pref("devtools.browserconsole.filter.serverinfo", false);
pref("devtools.browserconsole.filter.serverlog", false);
pref("devtools.browserconsole.filter.serverwarn", false);
pref("devtools.browserconsole.filter.serviceworkers", true);
pref("devtools.browserconsole.filter.sharedworkers", true);
pref("devtools.browserconsole.filter.windowlessworkers", true);
pref("devtools.browserconsole.new-frontend-enabled", false);
pref("devtools.changesview.enabled", false);
pref("devtools.computed.boxmodel.opened", true);
pref("devtools.debugger.features.breakpoints-dropdown", false);
pref("devtools.eventsview.enabled", false);
pref("devtools.hud.loglimit.console", 1000);
pref("devtools.hud.loglimit.cssparser", 1000);
pref("devtools.hud.loglimit.exception", 1000);
pref("devtools.hud.loglimit.network", 1000);
pref("devtools.inspector.colorWidget.enabled", false);
pref("devtools.inspector.split-rule-enabled", false);
pref("devtools.inspector.split-sidebar-toggle", false);
pref("devtools.webconsole.filter.csserror", true);
pref("devtools.webconsole.filter.csslog", false);
pref("devtools.webconsole.filter.cssparser", false);
pref("devtools.webconsole.filter.exception", true);
pref("devtools.webconsole.filter.jslog", false);
pref("devtools.webconsole.filter.jswarn", true);
pref("devtools.webconsole.filter.netwarn", true);
pref("devtools.webconsole.filter.network", true);
pref("devtools.webconsole.filter.networkinfo", false);
pref("devtools.webconsole.filter.secerror", true);
pref("devtools.webconsole.filter.secwarn", true);
pref("devtools.webconsole.filter.servererror", false);
pref("devtools.webconsole.filter.serverinfo", false);
pref("devtools.webconsole.filter.serverlog", false);
pref("devtools.webconsole.filter.serverwarn", false);
pref("devtools.webconsole.filter.serviceworkers", true);
pref("devtools.webconsole.filter.sharedworkers", false);
pref("devtools.webconsole.filter.windowlessworkers", false);
pref("devtools.webconsole.new-frontend-enabled", true);
pref("dom.animations-api.pending-member.enabled", true);
pref("dom.compartment_per_addon", true);
pref("dom.forms.number", true);
pref("dom.ipc.cpows.allow-cpows-in-compat-addons", "{b9db16a4-6edc-47ec-a1f4-b86292ed211d},[email protected],{DDC359D1-844A-42a7-9AA1-88A850A938A8},privateTab@infocatcher,mousegesturessuite@lemon_juice.addons.mozilla.org,[email protected],[email protected],{AE93811A-5C9A-4d34-8462-F7B864FC4696},[email protected],{EF522540-89F5-46b9-B6FE-1829E2B572C6},{677a8f98-fd64-40b0-a883-b8c95d0cbf17},[email protected],fx-devtools,[email protected],{d10d0bf8-f5b5-c8b4-a8b2-2b9879e08c5d},{dc572301-7619-498c-a57d-39143191b318},[email protected],{86095750-AD15-46d8-BF32-C0789F7E6A32},[email protected],{91aa5abe-9de4-4347-b7b5-322c38dd9271},[email protected],[email protected],[email protected],{7b1bf0b6-a1b9-42b0-b75d-252036438bdc},s3crypto@data,{1e0fd655-5aea-4b4c-a583-f76ef1e3af9c},[email protected],{aff87fa2-a58e-4edd-b852-0a20203c1e17},{1018e4d6-728f-4b20-ad56-37578a4de76b},[email protected],[email protected],{b2e69492-2358-071a-7056-24ad0c3defb1},[email protected],{e4a8a97b-f2ed-450b-b12d-ee082ba24781},jid1-f3mYMbCpz2AZYl@jetpack,{8c550e28-88c9-4764-bb52-aa489cf2efcd},{37fa1426-b82d-11db-8314-0800200c9a66},{ac2cfa60-bc96-11e0-962b-0800200c9a66},[email protected],[email protected],[email protected],{fc6339b8-9581-4fc7-b824-dffcb091fcb7},[email protected],[email protected],[email protected],{73a6fe31-595d-460b-a920-fcc0f8843232},{46551EC9-40F0-4e47-8E18-8E5CF550CFB8},[email protected],@screen_maker,[email protected],[email protected],s3google@translator,[email protected],{C1A2A613-35F1-4FCF-B27F-2840527B6556},[email protected],[email protected],[email protected],[email protected],[email protected],{9AA46F4F-4DC7-4c06-97AF-5035170634FE},jid1-CikLKKPVkw6ipw@jetpack,[email protected],[email protected],{A065A84F-95B6-433A-A0C8-4C040B77CE8A},[email protected]");
pref("dom.ipc.cpows.forbid-cpows-in-compat-addons", true);
pref("dom.ipc.scheduler", false);
pref("dom.requestcontext.enabled", false);
pref("experiments.manifest.fetchIntervalSeconds", 86400);
pref("extensions.{972ce4c6-7e08-4474-a285-3208198ce6fd}.description", "chrome://browser/locale/browser.properties");
pref("extensions.{972ce4c6-7e08-4474-a285-3208198ce6fd}.name", "chrome://browser/locale/browser.properties");
pref("extensions.allow-non-mpc-extensions", true);
pref("extensions.dss.switchPending", false);
pref("general.skins.selectedSkin", "classic/1.0");
pref("gfx.downloadable_fonts.keep_variation_tables", false);
pref("layers.advanced.background-color", false);
pref("layers.advanced.background-image", 2);
pref("layers.advanced.border-layers", 2);
pref("layers.advanced.bullet-layers", 2);
pref("layers.advanced.canvas-background-color", 2);
pref("layers.advanced.caret-layers", false);
pref("layers.advanced.columnRule-layers", 2);
pref("layers.advanced.image-layers", 2);
pref("layers.advanced.outline-layers", 2);
pref("layers.advanced.solid-color", false);
pref("layers.advanced.table", false);
pref("layout.accessiblecaret.always_show_when_scrolling", true);
pref("layout.css.expensive-style-struct-assertions.enabled", false);
pref("layout.css.float-logical-values.enabled", true);
pref("layout.css.scoped-style.enabled", false);
pref("layout.css.scope-pseudo.enabled", true);
pref("layout.css.servo.chrome.enabled", true);
pref("layout.css.servo.enabled", true);
pref("layout.css.text-combine-upright.enabled", true);
pref("media.wmf.skip-blacklist", false);
pref("network.predictor.redirect-likely-confidence", 75);
pref("services.blocklist.changes.path", "/buckets/monitor/collections/changes/records");
pref("svg.path-caching.enabled", true);
pref("toolkit.telemetry.infoURL", "https://www.mozilla.org/legal/privacy/firefox.html#telemetry");

==CHANGED

pref("app.normandy.run_interval_seconds", 21600); // prev: 86400
pref("browser.newtabpage.activity-stream.feeds.section.topstories.options", "{\"api_key_pref\":\"extensions.pocket.oAuthConsumerKey\",\"hidden\":true,\"provider_icon\":\"pocket\",\"provider_name\":\"Pocket\",\"read_more_endpoint\":\"https://getpocket.com/explore/trending?src=fx_new_tab\",\"stories_endpoint\":\"https://getpocket.cdn.mozilla.net/v3/firefox/global-recs?version=3&consumer_key=$apiKey&locale_lang=en-US&feed_variant=default_spocs_off\",\"stories_referrer\":\"https://getpocket.com/recommendations\",\"topics_endpoint\":\"https://getpocket.cdn.mozilla.net/v3/firefox/trending-topics?version=2&consumer_key=$apiKey&locale_lang=en-US\",\"show_spocs\":false,\"personalized\":true}"); // prev: "{\"api_key_pref\":\"extensions.pocket.oAuthConsumerKey\",\"hidden\":true,\"provider_description\":\"pocket_description\",\"provider_icon\":\"pocket\",\"provider_name\":\"Pocket\",\"read_more_endpoint\":\"https://getpocket.com/explore/trending?src=fx_new_tab\",\"stories_endpoint\":\"https://getpocket.cdn.mozilla.net/v3/firefox/global-recs?version=3&consumer_key=$apiKey&locale_lang=en-US&feed_variant=default_spocs_off\",\"stories_referrer\":\"https://getpocket.com/recommendations\",\"privacy_notice_link\":\"https://www.mozilla.org/privacy/firefox/#suggest-relevant-content\",\"disclaimer_link\":\"https://getpocket.com/firefox/new_tab_learn_more\",\"topics_endpoint\":\"https://getpocket.cdn.mozilla.net/v3/firefox/trending-topics?version=2&consumer_key=$apiKey&locale_lang=en-US\",\"show_spocs\":false,\"personalized\":true}"
pref("devtools.debugger.features.map-scopes", true); // prev: false
pref("extensions.geckoProfiler.getSymbolRules", "localBreakpad,remoteBreakpad,dump_syms.exe"); // prev: "localBreakpad,remoteBreakpad"
pref("extensions.langpacks.signatures.required", true); // prev: false
pref("extensions.legacy.exceptions", "[email protected],@testpilot-containers,jid1-NeEaf3sAHdKHPA@jetpack,@activity-streams,[email protected],@testpilot-addon,@min-vid,[email protected],[email protected],[email protected],[email protected]"); // prev: "{972ce4c6-7e08-4474-a285-3208198ce6fd},[email protected],@testpilot-containers,jid1-NeEaf3sAHdKHPA@jetpack,@activity-streams,[email protected],@testpilot-addon,@min-vid,[email protected],[email protected],[email protected],[email protected]"
pref("extensions.webextensions.tabhide.enabled", true); // prev: false
pref("font.name-list.emoji", "Segoe UI Emoji, Twemoji Mozilla"); // prev: "Segoe UI Emoji, EmojiOne Mozilla"
pref("gfx.webrender.blob-images", true); // prev: 1
pref("image.mem.shared", true); // prev: 2
pref("layers.omtp.paint-workers", -1); // prev: 1
pref("layers.tile-height", 512); // prev: 256
pref("layers.tile-width", 512); // prev: 256
pref("layout.css.moz-document.content.enabled", false); // prev: true
pref("lightweightThemes.selectedThemeID", "[email protected]"); // prev: ""
pref("media.wmf.amd.vp9.enabled", false); // prev: true
pref("network.http.throttle.version", 2); // prev: 1
pref("network.trr.blacklist-duration", 1200); // prev: 259200

@earthlng
Copy link
Contributor Author

earthlng commented May 26, 2018

bugzilla tickets for some of the remaining prefs

  • browser.storageManager.enabled
    Bug 1428306 - Remove browser.storageManager.enabled pref

  • browser.tabs.remote.warmup.enabled
    Bug 1457651 - Re-enable tab warming on Tier3 platforms.
    Bug 1456602 - Enable tab warming for Windows and Linux on all channels.
    Bug 1423220 - Enable tab warming by default for Nightly builds.

  • dom.indexedDB.storageOption.enabled
    Bug 1451486 - Part 1 - Ignore the storage attribute on indexedDB.open() by default.

  • dom.keyboardevent.dispatch_during_composition
    Bug 1446401 - Start to dispatch "keydown" event and "keyup" event even during in composition in Nightly and early Beta

  • experiments.enabled
    Bug 1420908: Remove telemetry experiments.

  • experiments.manifest.uri
    Bug 1420908: Remove telemetry experiments.

  • experiments.supported
    Bug 1450801 Part 1: Remove front-end (about:addons) support for telemetry experiments.

  • extensions.legacy.exceptions
    Bug 1372694 - Stop making the default theme a heavyweight theme.

  • extensions.webextensions.tabhide.enabled
    Bug 1455040 - Enable tab hiding API by default.

  • gfx.downloadable_fonts.validate_variation_tables
    Bug 1341088 - Enable validation of opentype variation tables in downloadable fonts, and replace the keep_variation_tables pref with validate_variation_tables (default=true).

  • layout.css.moz-document.content.enabled
    Bug 1422245 Disable @-moz-document in content pages

  • network.cookie.move.interval_sec
    Bug 1454100 - Move cookies around every X seconds

  • network.jar.block-remote-files
    Bug 1427726 - remove support for remote JAR files,

  • network.jar.open-unsafe-types
    Bug 1427726 - remove support for remote JAR files,

  • security.block_ftp_subresources
    Bug 1452701 - Add pref to allow FTP subresources.

  • services.blocklist.signing.enforced
    Bug 1397230 - Generalize blocklist clients to remote settings clients

@earthlng
Copy link
Contributor Author

It looks like the 4th pref in 0501 experiments.activeExperiment was also removed with 1420908

@earthlng
Copy link
Contributor Author

earthlng commented Jun 3, 2018

we can also remove services.blocklist.signing.enforced rather than deprecate it, because it's default true since FF50

Thorin-Oakenpants added a commit that referenced this issue Jun 4, 2018
Both deprecated in FF61, but we'll remove them from the user.js
- `services.blocklist.signing.enforced` is default true since FF50
- `browser.storageManager.enabled` only controls "Site Data" UI visibility
@earthlng
Copy link
Contributor Author

earthlng commented Jun 10, 2018

@earthlng

This comment has been minimized.

@earthlng
Copy link
Contributor Author

earthlng commented Jun 20, 2018

61b14 changes since 61b6

new

pref("browser.newtabpage.activity-stream.asrouter.snippetsUrl", "");
pref("layout.css.moz-document.url-prefix-hack.enabled", true); // 61b6: false
pref("services.sync.engine.bookmarks.validation.enabled", true);
pref("services.sync.engine.passwords.validation.enabled", true);
pref("shield.savant.enabled", false);
pref("shield.savant.loglevel", "warn");

removed, renamed or hidden

pref("geo.provider.ms-windows-location", false);

changed

pref("browser.cache.offline.insecure.enable", false); // prev: true
pref("browser.newtabpage.activity-stream.telemetry.ut.events", true); // prev: false
pref("browser.startup.blankWindow", true); // prev: false
pref("device.sensors.ambientLight.enabled", false); // prev: true
pref("device.sensors.proximity.enabled", false); // prev: true
pref("dom.keyboardevent.dispatch_during_composition", true); // prev: false
pref("dom.registerContentHandler.enabled", false); // prev: true
pref("geo.wifi.uri", "https://location.services.mozilla.com/v1/geolocate?key=%MOZILLA_API_KEY%"); // prev: "https://www.googleapis.com/geolocation/v1/geolocate?key=%GOOGLE_API_KEY%"
pref("layout.display-list.retain", true); // prev: false
pref("media.wmf.amd.vp9.enabled", false); // prev: true
pref("network.tcp.tcp_fastopen_enable", true); // prev: false
pref("privacy.usercontext.about_newtab_segregation.enabled", true); // prev: false

EDIT: updated 1st post

@earthlng earthlng changed the title ToDo: diffs FF60-FF61b6 ToDo: diffs FF60-FF61b14 Jun 20, 2018
@earthlng
Copy link
Contributor Author

earthlng commented Jun 26, 2018

61.0 changes since 61b14

changed

pref("app.update.channel", "beta"); // prev: "release"
pref("app.update.url.details", "https://www.mozilla.org/%LOCALE%/firefox/beta/notes"); // prev: "https://www.mozilla.org/%LOCALE%/firefox/notes"
pref("app.update.url.manual", "https://www.mozilla.org/firefox/beta"); // prev: "https://www.mozilla.org/firefox/"
pref("devtools.devedition.promo.enabled", true); // prev: false
pref("toolkit.telemetry.enabled", true); // prev: false

EDIT: updated 1st post

@earthlng earthlng changed the title ToDo: diffs FF60-FF61b14 ToDo: diffs FF60-FF61 Jun 26, 2018
@earthlng
Copy link
Contributor Author

new hidden pref:

// Disable using UNC paths (TBB bug 26424 and Mozilla's bug 1413868)
user_pref("network.file.disable_unc_paths", true);

uplifted all the way back to and including ESR52

@earthlng
Copy link
Contributor Author

earthlng commented Jul 3, 2018

I'd say we force-disable shield.savant.enabled because fuck shield.

I will definitely also disable tab warmup because I don't want FF to start doing something whenever I hover over a background tab with my mouse. But IDK if it's worth adding under 5000.

And lets not forget about this either. The bugzilla for it is still Access Denied.
I think this is about a potential proxy bypass and is definitely more severe in TBB than vanilla FF. But since most people will never really need a website (??) to access a UNC path anyway, it shouldn't be a problem if we add it IMHO.

@Atavic
Copy link

Atavic commented Jul 3, 2018

error is the log level below warn.

@Atavic
Copy link

Atavic commented Jul 3, 2018

A fresh bugzilla. And it has Critical Priority.

@earthlng
Copy link
Contributor Author

earthlng commented Jul 5, 2018

this is what it looks like in FF60:

1

0102+0103 could use a [SETTING-ESR60].

re: 0102 ...

need to check that those values 0=blank 1=home still exist

they do

work out what is the default is and what it changes to/from when flicking between the options in the new UI

default is 1. In FF61+ it toggles between 1 and 3

0103: I don't really like the "or use an extension". A newtab extension has nothing to do with privacy/security

re: 0104: "I do not think the preload does anything any more" - in FF61+ it's obsolete because it's checked together with browser.newtabpage.enabled and if that's false then so is newtab preloading. But in ESR60 and ESR52 it's slightly different and for that reason I'd say we keep it.

if 0102 is only about previous session then maybe this could be with the other session stuff?

it's about what happens on startup and thus fits perfectly where it is right now, IMO.

ps: I wouldn't mind activating both 0102 and 0103 and setting them to 0 and "about:blank" to make sure that no websites start loading before all extensions are ready.

@earthlng
Copy link
Contributor Author

earthlng commented Jul 5, 2018

some people set a custom url, others use an extension

yeah but most people don't use either and IMHO it should be the people using custom urls or extensions that should set an override and not the other way around. Also, people might not realize that when they have a homepage set and startup set to 1 (default) that the site will start to load before all their extensions are ready.

@earthlng
Copy link
Contributor Author

earthlng commented Jul 5, 2018

wow they really fucked it up big time! what a fucking mess

Let's just keep it simple and fuck all the infos and settings and shit

/* 0102: set a blank startup-, home- and newtab page ***/
user_pref("browser.startup.page", 0); // 0=blank, 1=home, 2=last visited, 3=resume previous session
user_pref("browser.startup.homepage", "about:blank");
user_pref("browser.newtabpage.enabled", false);
user_pref("browser.newtab.preload", false);

Thorin-Oakenpants added a commit that referenced this issue Jul 5, 2018
FF61 introduced quite a few changes, including removing the ability to set a blank startpage in the UI, and a new Home options tab with unified Activity Stream (AS) defaults and dropdown options. Because the only way to stop AS on startup is to enforce a blank page (pref 0102), and setting this auto changes `home+newwindow` (0103) and `newtab` (0104) to a blank page, then we're just going to go ahead and enforce that on all of them.

For more info see the discussion in #426
@earthlng
Copy link
Contributor Author

earthlng commented Jul 6, 2018

AFAIK tab warmup is not about making connections and stuff. It's about doing the visual parsing and processing of the page, DOM, etc so that it displays faster when you switch to that tab. We don't need to add it because it's probably not a big issue and most people are so performance hungry these days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants