zkutils: add generate groth16 solidity verifier command #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rikysya
force-pushed
the
yv/zkutils/solidity-verifier
branch
3 times, most recently
from
7554a1d to
d0e3bf4
Compare
rikysya
changed the title
rikysya
changed the title
akorchyn
reviewed
Sep 4, 2023
| curve: String, | ||
| #[serde(rename = "nPublic")] | ||
| n_public: i128, | ||
| vk_alpha_1: [String; 3], |
There was a problem hiding this comment.
why vk_alpha_1 is 3 element vector if stpl defines it as 2 element vector. (same for vk_beta, vk_gamma, vk_delta)
There was a problem hiding this comment.
Because when u export a verification key o json in snarkjs it has 3 elements in the array, so it is parsed as 3 element vector. However, that third element is not needed in the template
Adds a command `solidity verifier` to generate snarkjs like solidity verifier contract which calls groth16 precompile under the hood.
rikysya
force-pushed
the
yv/zkutils/solidity-verifier
branch
from
793b340 to
681d073
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a command
solidity verifierto generate snarkjs like solidity verifier contract which calls groth16 precompile under the hood.