-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gas estimation for Zero knowledge precompile #151
base: main
Are you sure you want to change the base?
Conversation
Cargo.toml
Outdated
@@ -161,6 +161,7 @@ fc-rpc-core = { version = "1.1.0-dev", git = "https://github.com/AstarNetwork/fr | |||
|
|||
# Frontier Primitive | |||
fc-storage = { version = "1.0.0-dev", git = "https://github.com/AstarNetwork/frontier.git", branch = "polkadot-v0.9.40", default-features = false } | |||
fp-account = { version = "1.0.0-dev", git = "https://github.com/AstarNetwork/frontier.git", branch = "polkadot-v0.9.40", default-features = false } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@luckychacha Why do we enclude this from the outside repo. Can we for it maybe? @xcthulhu What do you think? Otherwise we will have a potential security hole if our installation depends on third part githubs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- The dependency
fp-account
in my requirements is used to build the mock runtime for benchmark's unit tests, and thus is placed under[dev-dependencies]
in theruntime-common
module. It will not be included in the release version. Moreover, I have found alternative ways to build the mock runtime, so I will remove thefp-account.workspace = true
entry from theruntime-common
'sCargo.toml
file under[dev-dependencies]
. - I have noticed that our cargo.toml file contains a patch for this dependency, pointing to our forked
frontier
project:
# Temporary, leaks the std feature in the non-std env. Until https://github.com/AstarNetwork/frontier/pull/84 is merged.
[patch."https://github.com/AstarNetwork/frontier.git"]
fp-account = { git = "https://github.com/GoldenGateGGX/frontier.git", branch = "polkadot-v0.9.40" }
This patch ensures that we are actually utilizing our own forked version of the frontier
project rather than the one under AstarNetwork
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see why we include code from AstarNetwork instead of forking it and including from our own repo
…/ggxchain/ggxnode into gas-estimation-for-zk-precompile
No much sense to be honest to fork everything we use. We don't plan to adjust it, so why bother forking. |
No description provided.