Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Take default-features into account #30

Merged
merged 6 commits into from
Aug 28, 2023
Merged

Take default-features into account #30

merged 6 commits into from
Aug 28, 2023

Conversation

ggwpez
Copy link
Owner

@ggwpez ggwpez commented Aug 28, 2023

Needed for paritytech/polkadot-sdk#1194

Changes to lint propagate-features:

  • If a crate A depends on a crate B and enables its default features, then now all features of B that are transitively enabled by its default feature will also count as being enabled. Note that it only considers features that B enables on itself. It could also check for transitive dependencies in the form of B/G -> C/F -> B/F but it will only allow paths that consist solely of B/* to keep things simple.

Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
@ggwpez ggwpez merged commit 22e04c5 into master Aug 28, 2023
16 checks passed
@ggwpez ggwpez deleted the dev branch August 28, 2023 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant