Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

romio341: continuation of modernize MPICH 3.4.1 romio #6

Conversation

markalle
Copy link

The official mpich romio PRs I checked into included old-style
MPI calls, so those needed modernized same as an earlier
commit. I do think both of the modernize PRs could be put
into mpich.

Signed-off-by: Mark Allen [email protected]

The official mpich romio PRs I checked into included old-style
MPI calls, so those needed modernized same as an earlier
commit.  I do think both of the modernize PRs could be put
into mpich.

Signed-off-by: Mark Allen <[email protected]>
@markalle
Copy link
Author

@ggouaillardet
I think we need this one too for the romio refresh, otherwise my batch of mpich PRs seems to have left your romio refresh not building because of it having an old-style MPI call

@ggouaillardet
Copy link
Owner

got it

just to be clear, the old-style code modernized in this PR is not from upstream ROMIO 3.4.1 but this subsequent back ported fix

commit fd408ddbde82c1b9d599d563bc3871214da432cb
Author: Mark Allen <[email protected]>
Date:   Tue Apr 13 12:05:24 2021 -0500

    [mpich romio 73a3eba] darray needs a resize in the block()/cyclic() subtype creation

@ggouaillardet ggouaillardet merged commit c671da5 into ggouaillardet:topic/romio341_refresh Apr 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants