Refactor quantized processing functions #509
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To avoid code duplication when implementing additional quantization formats (#456), refactor the
forward_mul_mat
andforward_get_rows
functions to use a table of function pointers, indexed byggml_type
.This makes some functions non-inlined, I didn't see a regression in performance on my machine.
I tried to fix the "unused variable" warnings without complicating things too much, some are used in
assert
s.