Validate features and device mismatches in pass beginnings #6497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ErichDonGubler
added
area: validation
ErichDonGubler
force-pushed
the
validate-pass-beginning-better
branch
from
3510939
to
3951072
Compare
nical
approved these changes
Nov 5, 2024
|
Figured out what CTS tests cover these checks, edited OP to note that. Will confirm that consumption in Firefox makes these EDIT: Ah, nevermind, we'll figure that out later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connections
Found over the course of testing Firefox's query set implementation in bug 1838729.
Description
-
Testing
CTS coverage for these tests:
webgpu:api,validation,capability_checks,features,query_types:createQuerySet:*webgpu:api,validation,capability_checks,features,query_types:timestamp:*webgpu:api,validation,encoding,beginComputePass:timestamp_query_set,device_mismatch:*webgpu:api,validation,encoding,beginRenderPass:timestamp_query_set,device_mismatch:*webgpu:api,validation,encoding,beginRenderPass:occlusion_query_set,device_mismatch:*Ensure that the above tests are changed by this validation.
Checklist
cargo fmt.taplo format.cargo clippy. If applicable, add:--target wasm32-unknown-unknown--target wasm32-unknown-emscriptencargo xtask testto run tests.CHANGELOG.md. See simple instructions inside file.