-
Notifications
You must be signed in to change notification settings - Fork 908
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Raise MSRV to Rust 1.80 #6105
base: trunk
Are you sure you want to change the base?
Raise MSRV to Rust 1.80 #6105
Conversation
5b300f7
to
13db95e
Compare
Heeey, we're finally running into the same annoying errors here that I wasn't sure what to do with locally when I saw them:
☝🏻 @cwfitzgerald, @Wumpf: Not sure how to best proceed here, but I haven't given it many brain cycles, either. Will dedicate more in the absence of feedback in the next day or so. |
3aa12e9
to
b5973ab
Compare
a7cfba6
to
4e2f6ce
Compare
Leaving this as a draft until we actually have the option to upgrade to Rust 1.80. We might be able to hoist the upgrade to |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
4e2f6ce
to
c229479
Compare
b8278cb
to
0adf9c8
Compare
6347080
to
2215894
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We seem to have UB in the GL backend that rust is now catching.
2215894
to
b838aa7
Compare
Regressed by [gfx-rs#6354](https://github.com/gfx-rs/wgpu/pull/6354/files#diff-1dd0973ceb242a02442d33e422f9dff40e007b505d0ee726613e1763e61e768dR2809) (CC @jimb). Hopefully will get plugged by [gfx-rs#6105](gfx-rs#6105).
b838aa7
to
f9bb783
Compare
Regressed by [#6354](https://github.com/gfx-rs/wgpu/pull/6354/files#diff-1dd0973ceb242a02442d33e422f9dff40e007b505d0ee726613e1763e61e768dR2809) (CC @jimb). Hopefully will get plugged by [#6105](#6105).
181ab8d
to
20c76bd
Compare
Consumes [`cfg_aliases`#8](katharostech/cfg_aliases#8) to eliminate warnings from `rustc`.
This resolves remaining outstanding cases that offend [`--check-cfg` in Rust 1.80](https://blog.rust-lang.org/2024/07/25/Rust-1.80.0.html#checked-cfg-names-and-values) in `wgpu-core`.
…ck-cfg` in `wgpu_{hal,types}`
20c76bd
to
3cf47a6
Compare
3cf47a6
to
6edb2b1
Compare
`std::mem::{size,align}_of{,_val}` was added to `std::prelude` in Rust 1.80; see [`rust`#123168](rust-lang/rust#123168).
Weaken our dependence on the `once_cell` crate by using functionality from `std` instead that was upstreamed from `once_cell`, this time with what's available in Rust 1.80+. It's not yet possible to eliminate this dependency entirely, but do what we can for now.
6edb2b1
to
c7e6991
Compare
Depends on Preemptunused_qualifications
lints triggered in Rust 1.80 #6147.Depends on Yet more preempting of Rust 1.80 lints #6180.