Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve lints in versions _newer_ than Rust 1.76 while still in Rust 1.76 #6103

Merged
merged 7 commits into from
Aug 13, 2024
Merged

Resolve lints in versions _newer_ than Rust 1.76 while still in Rust 1.76 #6103

merged 7 commits into from
Aug 13, 2024

Conversation

ErichDonGubler
Copy link
Member

@ErichDonGubler ErichDonGubler commented Aug 12, 2024 •
edited
Loading

Recommended review experience: commit-by-commit. These commits build individually, and do not need to be squashed.

@ErichDonGubler ErichDonGubler added area: infrastructure Testing, building, coordinating issues kind: refactor Making existing function faster or nicer labels Aug 12, 2024
@ErichDonGubler ErichDonGubler self-assigned this Aug 12, 2024
@ErichDonGubler ErichDonGubler requested review from a team as code owners August 12, 2024 11:48
@ErichDonGubler ErichDonGubler mentioned this pull request Aug 12, 2024
Closed
cwfitzgerald
cwfitzgerald previously requested changes Aug 12, 2024
View reviewed changes
naga/src/valid/expression.rs Show resolved Hide resolved
@ErichDonGubler ErichDonGubler dismissed cwfitzgerald’s stale review August 12, 2024 12:04

My changes are valid, yo. 😤

Wumpf
Wumpf approved these changes Aug 12, 2024
View reviewed changes
Copy link
Member

@Wumpf Wumpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

naga/src/valid/expression.rs Show resolved Hide resolved
@ErichDonGubler
Copy link
Member Author

Just waiting on @gfx-rs/naga here. I think it's important that they/we are informed, but I don't consider them a necessary blocking reviewer set; will merge in a couple of days if I don't get a response here.

@ErichDonGubler
Copy link
Member Author

@Wumpf: Just as a heads-up, I included 2bbfc85 and af81ed5, which I think are uncontroversial.

@ErichDonGubler ErichDonGubler mentioned this pull request Aug 12, 2024
Merged
@ErichDonGubler
Copy link
Member Author

ErichDonGubler commented Aug 12, 2024 •
edited
Loading

@Wumpf: Also discovered that I could add 316e845 at this point, rather than a later one. 🥳

@ErichDonGubler ErichDonGubler enabled auto-merge (rebase) August 13, 2024 07:26
@ErichDonGubler ErichDonGubler merged commit 5533c37 into gfx-rs:trunk Aug 13, 2024
25 checks passed
@ErichDonGubler ErichDonGubler deleted the rust-lints-with-1.76 branch August 26, 2024 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teoxoy teoxoy teoxoy approved these changes

@Wumpf Wumpf Wumpf approved these changes

@cwfitzgerald cwfitzgerald Awaiting requested review from cwfitzgerald

Assignees

@ErichDonGubler ErichDonGubler

Labels
area: infrastructure Testing, building, coordinating issues kind: refactor Making existing function faster or nicer
Projects
WebGPU for Firefox
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ErichDonGubler @Wumpf @cwfitzgerald @teoxoy