[naga] Validate CallResult and AtomicResult population.
#5741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimblandy
force-pushed
the
naga-validate-emit-result-expressions
branch
from
dba1931
to
5247519
Compare
Validate that `CallResult` and `AtomicResult` expressions actually have their values provided by `Call` and `Atomic` statements, and not `Emit` statements. Fixes gfx-rs#5740.
Add tests to ensure that validation checks that `CallResult` and `AtomicResult` expressions actually have their values provided by `Call` and `Atomic` statements, and not `Emit` statements.
jimblandy
force-pushed
the
naga-validate-emit-result-expressions
branch
from
5247519
to
5d0ba3b
Compare
|
This can be reviewed, but perhaps the tests should also cover all the other |
|
For the record, this came up while reviewing #5383. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add validation to ensure that
CallResultandAtomicResultexpressions actually have their values provided byCallandAtomicstatements, and notEmitstatements.Fixes #5740.