-
Notifications
You must be signed in to change notification settings - Fork 933
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement F16 support in shaders #5701
base: trunk
Are you sure you want to change the base?
Conversation
I've marked this as ready for review, as the wgpu specific logic is implemented and would be great to start iterating on it. 2 main blockers are:
|
Dogfooding works! Fixed a few bugs in 30e12b5. Still waiting on upstream. |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
One thing I'm concerned is that the polyfills we have in some of the backends might not support |
This comment was marked as resolved.
This comment was marked as resolved.
9c6a9b3
to
9f33e0e
Compare
This comment was marked as outdated.
This comment was marked as outdated.
from gpuweb/gpuweb#2512 I think we have to do the casting ourselves. Dawn also seems to do this. We can do it in a different PR though. What I find interesting is that the proposal talked about SM6.2 & Native16BitShaderOpsSupported enabling support for f16 IO, I guess the Nvidia compiler that ingests DXIL will do the casting. It probably does the casting regardless of frontend and that's why people report this working on Vulkan as well despite |
f4e1d2e
to
b936c71
Compare
This comment was marked as outdated.
This comment was marked as outdated.
d9d0bed
to
b42a1ca
Compare
5e0283c
to
cbd6cc5
Compare
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
e556c47
to
aaa83dd
Compare
Co-Authored-By: Erich Gubler <[email protected]>
aaa83dd
to
68bb221
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should make sure that we are properly validating As
casts of matrices, because that code currently assumes that all matrices have the same kind (#6441).
Super awesome work folks, really appreciate it!! 👏 <3 |
Connections
enable …;
that reports nice errors #6424.enable
directive #5476.Checklist for merge-ability
Additional context
F16 is available in >=SM6.2: https://github.com/microsoft/DirectXShaderCompiler/wiki/16-Bit-Scalar-Types