Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement F16 support in shaders #5701

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from

Conversation

FL33TW00D
Copy link
Contributor

@FL33TW00D FL33TW00D commented May 13, 2024

Connections

Checklist for merge-ability

Additional context

F16 is available in >=SM6.2: https://github.com/microsoft/DirectXShaderCompiler/wiki/16-Bit-Scalar-Types

@FL33TW00D FL33TW00D mentioned this pull request May 14, 2024
@FL33TW00D FL33TW00D changed the title feature: Parse enable directives feature: Parse enable directives & SHADER-F16 support May 14, 2024
@FL33TW00D FL33TW00D marked this pull request as ready for review May 15, 2024 21:19
@FL33TW00D FL33TW00D requested review from a team as code owners May 15, 2024 21:19
@FL33TW00D
Copy link
Contributor Author

I've marked this as ready for review, as the wgpu specific logic is implemented and would be great to start iterating on it.

2 main blockers are:

  1. Merging of the PR on half-rs.
  2. hexf-parse improved implementation.

@FL33TW00D
Copy link
Contributor Author

FL33TW00D commented May 20, 2024

Dogfooding works! Fixed a few bugs in 30e12b5. Still waiting on upstream.

naga/src/proc/constant_evaluator.rs Outdated Show resolved Hide resolved
naga/src/proc/constant_evaluator.rs Outdated Show resolved Hide resolved
naga/src/proc/constant_evaluator.rs Outdated Show resolved Hide resolved
naga/src/proc/constant_evaluator.rs Outdated Show resolved Hide resolved
naga/src/proc/constant_evaluator.rs Outdated Show resolved Hide resolved
naga/src/front/wgsl/parse/lexer.rs Outdated Show resolved Hide resolved
naga/src/front/wgsl/parse/ast.rs Outdated Show resolved Hide resolved
naga/src/back/msl/writer.rs Outdated Show resolved Hide resolved
naga/src/back/msl/writer.rs Outdated Show resolved Hide resolved
naga/src/back/spv/writer.rs Show resolved Hide resolved
@teoxoy

This comment was marked as resolved.

@FL33TW00D

This comment was marked as resolved.

@teoxoy
Copy link
Member

teoxoy commented Jun 13, 2024

One thing I'm concerned is that the polyfills we have in some of the backends might not support f16. It would be worth adding more tests covering the built-in functions and operations that support f16. Execution tests would be great as well, they live in tests/tests/shader.

@teoxoy

This comment was marked as resolved.

@teoxoy teoxoy self-assigned this Jun 13, 2024
@FL33TW00D FL33TW00D force-pushed the feature/enable branch 2 times, most recently from 9c6a9b3 to 9f33e0e Compare June 14, 2024 14:20
@ErichDonGubler

This comment was marked as outdated.

@ErichDonGubler ErichDonGubler added type: enhancement New feature or request api: webgpu Issues with direct interface with WebGPU labels Jun 14, 2024
@teoxoy
Copy link
Member

teoxoy commented Aug 9, 2024

It is possible to use FP16 in user-defined pipeline input/output variables. However some Vulkan devices, which support other usages in this extension like FP16 built-in function and storage buffer, don’t support this usage. For capabilities reasons, we may suggest not enabling using FP16 as pipeline input or output with this extension. However, this usage can also be emulated on Vulkan devices with no native support for this usage (storageInputOutput16).

from gpuweb/gpuweb#2512

I think we have to do the casting ourselves. Dawn also seems to do this. We can do it in a different PR though.

What I find interesting is that the proposal talked about SM6.2 & Native16BitShaderOpsSupported enabling support for f16 IO, I guess the Nvidia compiler that ingests DXIL will do the casting. It probably does the casting regardless of frontend and that's why people report this working on Vulkan as well despite storageInputOutput16 not being supported. While it's unlikely this will change we shouldn't rely on this behavior.

@ErichDonGubler

This comment was marked as outdated.

ErichDonGubler

This comment was marked as resolved.

@ErichDonGubler ErichDonGubler force-pushed the feature/enable branch 2 times, most recently from d9d0bed to b42a1ca Compare October 18, 2024 20:47
@ErichDonGubler ErichDonGubler changed the title feature: Parse enable directives & SHADER-F16 support feature: implement F16 support in shaders Oct 18, 2024
@ErichDonGubler ErichDonGubler force-pushed the feature/enable branch 2 times, most recently from 5e0283c to cbd6cc5 Compare October 18, 2024 20:49
@ErichDonGubler ErichDonGubler changed the title feature: implement F16 support in shaders feat: implement F16 support in shaders Oct 18, 2024
@ErichDonGubler

This comment was marked as resolved.

@teoxoy

This comment was marked as resolved.

@ErichDonGubler ErichDonGubler force-pushed the feature/enable branch 2 times, most recently from e556c47 to aaa83dd Compare October 24, 2024 17:56
Copy link
Member

@jimblandy jimblandy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should make sure that we are properly validating As casts of matrices, because that code currently assumes that all matrices have the same kind (#6441).

@raphamorim
Copy link

Super awesome work folks, really appreciate it!! 👏 <3
@FL33TW00D please lemme know if I can help in anything 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: webgpu Issues with direct interface with WebGPU area: cts Issues stemming from the WebGPU Conformance Test Suite area: naga back-end Outputs of naga shader conversion area: naga front-end area: naga processing Passes over IR in the middle lang: WGSL WebGPU Shading Language naga Shader Translator type: enhancement New feature or request
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

[meta] f16 support WGSL: Support the enable directive
6 participants