Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[spv-out] Move request_type_capabilities outside of LocalType lookup #5590

Merged
merged 11 commits into from
Apr 25, 2024

Conversation

atlv24
Copy link
Contributor

@atlv24 atlv24 commented Apr 23, 2024

Connections
Fixes #5569
Unblocks #5383

Description
Avoids incorrect caching as per #5569

Testing
Existing tests

Checklist

  • Run cargo fmt.
  • Run cargo clippy. If applicable, add:
    • --target wasm32-unknown-unknown
    • --target wasm32-unknown-emscripten
  • Run cargo xtask test to run tests.
  • Add change to CHANGELOG.md. See simple instructions inside file.

@atlv24 atlv24 requested a review from a team as a code owner April 23, 2024 17:31
naga/src/back/spv/writer.rs Outdated Show resolved Hide resolved
Copy link
Member

@teoxoy teoxoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@teoxoy teoxoy changed the title Move request_type_capabilities outside of LocalType lookup [spv-out] Move request_type_capabilities outside of LocalType lookup Apr 25, 2024
@teoxoy teoxoy merged commit 18ceb51 into gfx-rs:trunk Apr 25, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Atomics and Scalars are collapsed to the same LocalType
2 participants