Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement the device_set_device_lost_callback method for ContextWebGpu #5438

Merged
merged 2 commits into from
Mar 26, 2024

Conversation

suti
Copy link
Contributor

@suti suti commented Mar 26, 2024

Description
Implement the device_set_device_lost_callback method for ContextWebGpu.

Checklist

  • Run cargo fmt.
  • Run cargo clippy. If applicable, add:
    • --target wasm32-unknown-unknown
    • --target wasm32-unknown-emscripten
  • Run cargo xtask test to run tests.
  • Add change to CHANGELOG.md. See simple instructions inside file.

@suti suti requested a review from a team as a code owner March 26, 2024 13:53
@suti suti force-pushed the device_lose_callback_implement branch from dad7086 to 4a98178 Compare March 26, 2024 14:01
@suti suti force-pushed the device_lose_callback_implement branch from 4a98178 to e761ee6 Compare March 26, 2024 14:04
Copy link
Member

@Wumpf Wumpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh spooky, just commented on the changelog entry not being quite right and then it fixed itself 😄

Looking good, thank you very much!

CHANGELOG.md Outdated Show resolved Hide resolved
@suti suti requested a review from Wumpf March 26, 2024 14:28
@Wumpf Wumpf enabled auto-merge (squash) March 26, 2024 14:57
@Wumpf Wumpf merged commit b34219c into gfx-rs:trunk Mar 26, 2024
27 checks passed
@suti suti deleted the device_lose_callback_implement branch March 26, 2024 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants