Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: const feature defaults #5343

Merged
merged 2 commits into from
Mar 5, 2024
Merged

feat: const feature defaults #5343

merged 2 commits into from
Mar 5, 2024

Conversation

MultisampledNight
Copy link
Contributor

Connections
Link to the issues addressed by this PR, or dependent PRs in other repositories

Discussed on Matrix: https://matrix.to/#/!XFRnMvAfptAHthwBCx:matrix.org/$Nb3Nk7fnyG08QfzPnbxCvgBWnaPaYGRXqbC2ayHziCQ?via=matrix.org&via=mozilla.org&via=gitter.im

Description
Describe what problem this is solving, and how it's solved.

Previously, it was not possible to use the downlevel defaults in const as they were not marked as such. But nothing was stopping them from being marked const, as they are just sets of values.

Testing
Explain how this change is tested.

Not at all.

Checklist

  • Run cargo fmt.
  • Run cargo clippy. If applicable, add:
    • --target wasm32-unknown-unknown
    • --target wasm32-unknown-emscripten
  • Run cargo xtask test to run tests.
    • 2 failed, specifically these, but the failures look unrelated to my changes and more like due my setup
      • wgpu_test::shader::struct_layout::uniform_input
        [2024-03-05T09:33:43Z ERROR wgpu_test::expectations] Expected to fail due to [FailureReason { kind: Some(ValidationError), message: Some("a matrix with stride 8 not satisfying alignment to 16") }], but did not fail
      • wgpu-examples water
        test panicked: explicit panic although the comparison passed
  • Add change to CHANGELOG.md. See simple instructions inside file.

@MultisampledNight MultisampledNight requested a review from a team as a code owner March 5, 2024 09:39
Copy link
Member

@Wumpf Wumpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

neat, thank you!

@Wumpf Wumpf merged commit badb3c8 into gfx-rs:trunk Mar 5, 2024
27 checks passed
@MultisampledNight MultisampledNight deleted the feat-const-features branch March 5, 2024 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants