Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connections
Link to the issues addressed by this PR, or dependent PRs in other repositories
Discussed on Matrix: https://matrix.to/#/!XFRnMvAfptAHthwBCx:matrix.org/$Nb3Nk7fnyG08QfzPnbxCvgBWnaPaYGRXqbC2ayHziCQ?via=matrix.org&via=mozilla.org&via=gitter.im
Description
Describe what problem this is solving, and how it's solved.
Previously, it was not possible to use the downlevel defaults in
const
as they were not marked as such. But nothing was stopping them from being markedconst
, as they are just sets of values.Testing
Explain how this change is tested.
Not at all.
Checklist
cargo fmt
.cargo clippy
. If applicable, add:--target wasm32-unknown-unknown
--target wasm32-unknown-emscripten
cargo xtask test
to run tests.wgpu_test::shader::struct_layout::uniform_input
[2024-03-05T09:33:43Z ERROR wgpu_test::expectations] Expected to fail due to [FailureReason { kind: Some(ValidationError), message: Some("a matrix with stride 8 not satisfying alignment to 16") }], but did not fail
wgpu-examples
watertest panicked: explicit panic
although the comparison passedCHANGELOG.md
. See simple instructions inside file.