Fix the validation of vertex/index/instance ranges in render bundles #5144
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connections
Spec: https://gpuweb.github.io/gpuweb/#dom-gpurendercommandsmixin-draw
Description
The current bundle validation has two problems:
stride * count
whereas the specified formula isstride * (count - 1) + last_stride
wherelast_stride
is the space required to fit the last element (potentially smaller than the stride.This PR addresses these issues by implementing the spec pretty much verbatim, but for render bundles only. Regular encoders are unfortunately still not up to spec. One way would be to use the same validation but it will be more expensive since it has to be done for each draw call while the current validation gets away with doing most of the calculation only when switching pipelines. I think that I can adapt that to match the spec but it's going to be more complicated.
I'm eager to get at least the render bundle part fixed so that we get rid of an outstanding CTS crash.
Checklist
cargo fmt
.cargo clippy
.cargo xtask test
to run tests.