Discard draws when the instance/vertex/index count is zero #5137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ErichDonGubler
approved these changes
Jan 24, 2024
There was a problem hiding this comment.
I think this is still compliant based on my read of GPURenderCommandsMixin.draw, though I'm surprised that there's no validation/mention of this case for this. LGTM, but I wanted to loop in @teoxoy or @jimblandy to make sure I'm not missing anything with my lesser familiarity with the spec.
|
There is no validation simply because it is valid. The reason we have to discard these empty draws is to work around the backend having issues with it. |
|
Could we add documentation to hal that these are not valid calls to make? Arguably they should be valid calls and this be handled by the metal backend? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connections
Fixes #1879
Description
Discard draws when the instance/vertex/index count is zero
Checklist
cargo fmt.cargo clippy.cargo xtask testto run tests.